Univention Bugzilla – Full Text Bug Listing |
Summary: | error handling for "copy /etc/machine.secret into container" | ||
---|---|---|---|
Product: | UCS | Reporter: | Felix Botner <botner> |
Component: | App Center | Assignee: | Felix Botner <botner> |
Status: | CLOSED FIXED | QA Contact: | Dirk Wiesenthal <wiesenthal> |
Severity: | normal | ||
Priority: | P5 | CC: | gulden |
Version: | UCS 4.4 | ||
Target Milestone: | UCS 4.4-0-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | Development Internal | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: |
Description
Felix Botner
2019-05-24 11:12:43 CEST
> app in an undefiend state (neither remove nor re-install is possible now).
This is not true, the app is de-installed.
Better error handling would be good anyway.
6ca5659aa3d0e6a77230210c40c3972ce5f239e2 - univention-appcenter 0fc2d0ae57aedac9fba31b701652e63a8c59d751 - yaml OK, in my tests the error message is more or less doubled, but maybe in "real world errors"... better safe than sorry. This breaks the openid-connect-provider App. This app starts the container read-only and now the docker-cp fails. ok, back to creating the file in the overlay directory, if that fails raise DockerCouldNotStartContainer instead of the original exception- Does the error also add some value to the DockerCouldNotStartContainer error? It would be good to get additional feedback like for example "Failed to write /etc/machine.secret to container". (In reply to Nico Gulden from comment #6) > Does the error also add some value to the DockerCouldNotStartContainer > error? It would be good to get additional feedback like for example "Failed > to write /etc/machine.secret to container". yes, in case the creation of the machine.secret fails, DockerCouldNotStartContainer is raised with a message containing the exception and docker.logs from the container. OK, works |