Bug 49770

Summary: App Suggestions: Dynamic suggestions from App Center server
Product: UCS Reporter: Dirk Wiesenthal <wiesenthal>
Component: UMC - App-CenterAssignee: Dirk Wiesenthal <wiesenthal>
Status: CLOSED FIXED QA Contact: Felix Botner <botner>
Severity: normal    
Priority: P5 CC: botner
Version: UCS 4.4   
Target Milestone: UCS 4.4-0-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: Feature Request What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:

Description Dirk Wiesenthal univentionstaff 2019-07-01 15:25:47 CEST
We should download a recommendations.json and use that information instead of hard coding it in the UMC frontend. This way, we can quickly update the suggestions without using errata updates.
Comment 1 Dirk Wiesenthal univentionstaff 2019-07-01 15:32:07 CEST
Fixed in
  univention-appcenter 8.0.11-41A~4.4.0.201907011529

File is
  http://appcenter.software-univention.de/meta-inf/recommendations.json

The content is loaded with tools.umcpCommand("appcenter/recommendations", {"version": "v1"})

Needed to use some callbacks. query() should now be slightly slower.
Comment 2 Felix Botner univentionstaff 2019-07-02 09:46:07 CEST
"all" docker/appcenter tests failed, see

http://jenkins.knut.univention.de:8080/job/UCS-4.4/job/UCS-4.4-0/job/AutotestJoin/lastCompletedBuild/testReport/
Comment 3 Dirk Wiesenthal univentionstaff 2019-07-04 00:39:14 CEST
Adjusted dockertest.py to create a recommendations.json.
  ucs-test 9.0.2-115A~4.4.0.201907040023

Unfortunately, I built it too late for the nightly test run, so we need to wait until Friday. Or install ucs-test, execute one test and assume that if this one succeeds, they all will.
Comment 4 Felix Botner univentionstaff 2019-07-05 10:05:53 CEST
some tests still fail

(2019-07-05 01:32:29.361072) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.361174) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.373033) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.385951) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.386035) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.405225) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.405312) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.424368) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.424455) http://10.210.254.15/meta-inf/recommendations.json could not be downloaded. This seems to be a problem with the App Center server. Please try again later.
(2019-07-05 01:32:29.797777) dpkg-buildpackage: Warnung: Verwendung eines root-werde-Befehls, obwohl bereits root
(2019-07-05 01:32:29.862493) dpkg-buildpackage: Warnung: debian/rules ist nicht ausführbar: wird korrigiert
(2019-07-05 01:32:29.862659)  dpkg-source --before-build test-install-remove
(2019-07-05 01:32:30.118847)  fakeroot debian/rules clean
(2019-07-05 01:32:30.336450)  debian/rules build
(2019-07-05 01:32:30.589940)  fakeroot debian/rules binary

http://jenkins.knut.univention.de:8080/job/UCS-4.4/job/UCS-4.4-0/job/AutotestJoin/lastCompletedBuild/testReport/
Comment 5 Dirk Wiesenthal univentionstaff 2019-07-08 11:46:04 CEST
Fixed in
  univention-appcenter 8.0.11-43A~4.4.0.201907081107

Also renamed recommendations.json to suggestions.json
Comment 6 Felix Botner univentionstaff 2019-07-08 13:40:50 CEST
OK - suggestions.json (equal to former _getAppSuggestions list)
OK - umc-command -U Administrator -P univention "appcenter/suggestions" -o version=v1
OK - .suggestions.json copied during UMC appcenter update
OK - suggestions in UMC

TODO - jenkins Tests (wait for tomorrows results)
Comment 7 Felix Botner univentionstaff 2019-07-09 13:40:47 CEST
OK - jenkins
OK - yaml
Comment 8 Erik Damrose univentionstaff 2019-07-10 13:20:40 CEST
<http://errata.software-univention.de/ucs/4.4/179.html>