Bug 51131
| Summary: | univention-samba4 and univention-samba: make UCR templates python3-compatible | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Florian Best <best> |
| Component: | Samba4 | Assignee: | Florian Best <best> |
| Status: | CLOSED FIXED | QA Contact: | Arvid Requate <requate> |
| Severity: | normal | ||
| Priority: | P5 | CC: | requate |
| Version: | UCS 4.4 | ||
| Target Milestone: | UCS 4.4-4-errata | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| What kind of report is it?: | Development Internal | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | ||
| Max CVSS v3 score: | |||
| Bug Depends on: | |||
| Bug Blocks: | 51212 | ||
|
Description
Florian Best
univention-samba4.yaml 9be6c5ea2f2e | YAML Bug #51131 univention-samba4 (8.0.0-30) c9c4158805af | Bug #51131: make UCR templates compatible to python3 d6591ca45810 | Bug #51131: pep8; make UCR templates compatible to python3 The package univention-samba should also be migrated: univention-samba.yaml c34de7c9ca41 | YAML Bug #51131 univention-samba (13.0.0-8) cc95fda65251 | Bug #51131: make UCR templates compatible to python3 The space got lost in /etc/logrotate.d/winbind (univention-samba):
/var/log/samba/log.winbindd/var/log/samba/log.winbindd-idmap/var/log/samba/log.winbindd-dc-connect/var/log/samba/log.wb-BUILTIN/var/log/samba/log.wb-AR41I1/var/log/samba/log.wb-MEMBER13{
More generally: I'm not sure if this sys.stdout.write is useful in templates, I'd rather build up the contactenated string and then print() it. In some parts the original trailing comma ('print "foo",') was only there before the closing '@!@' to suppress an extra empty line. That's just cosmetics. But I don't care.
Fixed in: univention-samba (13.0.0-9) 228bca42bb10 | Bug #51131: fix print statements 6c0e5e913ae7 | Bug #51131: fix print statements univention-samba4 (8.0.0-31) 301c8a44c118 | Bug #51131: fix print statements Verified: * Code review * Commited templates are unchanged * Advisories |