Bug 51373

Summary: Migrate univention-system-activation to dh_python2
Product: UCS Reporter: Florian Best <best>
Component: GeneralAssignee: Florian Best <best>
Status: CLOSED FIXED QA Contact: Philipp Hahn <hahn>
Severity: normal    
Priority: P5 CC: gulden, hahn
Version: UCS 4.4   
Target Milestone: UCS 4.4-4-errata   
Hardware: All   
OS: Linux   
URL: https://hutten.knut.univention.de/mediawiki/index.php/Python_DebHelper_Migration
See Also: https://forge.univention.org/bugzilla/show_bug.cgi?id=46790
What kind of report is it?: Development Internal What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:
Bug Depends on:    
Bug Blocks: 28497    

Description Florian Best univentionstaff 2020-05-29 11:46:15 CEST
The package base/univention-system-activation should be migrated to use dh_python instead of python-support.

Migration-Guide: https://hutten.knut.univention.de/mediawiki/index.php/Python_DebHelper_Migration
Comment 1 Florian Best univentionstaff 2020-05-29 12:40:37 CEST
univention-system-activation (4.0.0-12)
f3be730fc313 | Bug #51373: migrate to dh_python

univention-system-activation.yaml
0074567c71af | YAML Bug #51373
Comment 2 Philipp Hahn univentionstaff 2020-05-29 15:39:16 CEST
OK: errata-announce  -V --onyl univention-system-activation.yaml
FIXED: 4b773ff6ea

OK: f3be730fc313
OK: flake8
OK: ucslint
FYI: There are 2 unused UCR files:
 conffiles/usr/lib/univention-system-setup/appliance-hooks.d/96_enable_system_activation
 conffiles/etc/sudoers.d/univention-system-activation
OK: apt-get install univention-system-activation
OK: /usr/sbin/univention-system-activation start
OK: walk through

[4.4-4] 9e321869fc Bug #51373 activation: Cleanup shell issues
 base/univention-system-activation/Makefile           |  2 +-
 .../debian/ucslint.overrides                         |  6 ++++++
 .../scripts/univention-system-activation             | 20 ++++++++++----------
 .../tests/01_import_license_string                   | 13 ++++++-------
 .../tests/02_import_license_file                     | 13 ++++++-------
 .../tests/03_error_import_without_parameters         |  4 +---
 .../tests/04_error_import_with_wrong_basedn          |  6 ++----
 .../tests/05_error_import_too_large_file             | 10 ++++------
 8 files changed, 36 insertions(+), 38 deletions(-)
Comment 3 Philipp Hahn univentionstaff 2020-05-29 15:40:30 CEST
(In reply to Philipp Hahn from comment #2)
> FYI: There are 2 unused UCR files:
>  conffiles/usr/lib/univention-system-setup/appliance-hooks.d/
> 96_enable_system_activation
>  conffiles/etc/sudoers.d/univention-system-activation

No, they are used, but not installed by debian/*.ucr, but by debian/*.install
Very unusual.
Documented in debian/ucslint.overrides.
Comment 4 Erik Damrose univentionstaff 2020-06-03 12:40:24 CEST
<http://errata.software-univention.de/ucs/4.4/619.html>
Comment 5 Florian Best univentionstaff 2020-08-18 14:48:53 CEST
*** Bug 50948 has been marked as a duplicate of this bug. ***