Bug 30798 - No progress during app center dry_run
No progress during app center dry_run
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 3.1
Other Linux
: P5 enhancement (vote)
: UCS 3.1-1-errata
Assigned To: Dirk Wiesenthal
Felix Botner
:
Depends on: 30984
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-15 15:53 CET by Stefan Gohmann
Modified: 2013-05-22 16:09 CEST (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Release Goal
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2013-03-15 15:53:31 CET
While checking all Master and Backup servers during the app center dry_run, no progress is shown.

There should be a progress bar with some informations or something similar.
Comment 1 Dirk Wiesenthal univentionstaff 2013-04-04 21:21:26 CEST
Put the whole appcenter/invoke in a giant thread. Now it is possible to poll progress not only during installation but also during dry_run just before that.

Used Bug#30984 because now the ProgressBar polls twice: Once during the dry_run phase, once during the installation phase. We have to manually stop the first polling although the method itself did not finish yet.
It would be possible to not use this. But then I would need to say "finished" twice during one operation and I feel uncomfortable doing that.

The progress bar reaches 100% after dry_run and jumps back to 0% when installation starts.

One dry_run is "atomic" i.e. there are no steps in between (nothing like "Component added", "apt-get update", "Software changes calculated", etc). There is only progress when a remote or the local server answered completely.

Because I needed a newer version of the frontend than present in errata3.1-1, I built it against 3.1-2 for now. Let me know what you think.

  univention-management-console-module-appcenter 2.0.140-1.117.201304042119
Comment 2 Alexander Kläser univentionstaff 2013-04-05 09:42:25 CEST
Is this really something that the ProgressBar should be able to handle - I do not see what exactly needs to be extended in the ProgressBar. IMHO should the module itself encapsulate several steps into transparent taks for the ProgressBar. This seems to be something module specific and not ProgressBar specific.
Comment 3 Dirk Wiesenthal univentionstaff 2013-04-05 21:51:02 CEST
New approach, less invasive: Just show a "spinning" progress bar stating "Performing software tests on involved systems". The check in the backend received a speed-up by using threads. This should roughly lead to the speed of "1 x single check" instead of "number of involved systems x single check" (maybe a bit slower during the second check when force=True).

Downside: Absolutely no real progress information. It's done when it's done, it just looks nicer.
Comment 4 Dirk Wiesenthal univentionstaff 2013-04-05 21:51:51 CEST
3.1-2:
  univention-management-console-module-appcenter 2.0.141-1.118.201304052144

errata not built until further decision (if this approach is acceptable).
Comment 5 Dirk Wiesenthal univentionstaff 2013-04-10 20:18:17 CEST
Built for 3.1-1:
  univention-management-console-module-appcenter 2.0.139-2.120.201304102007

Changelog updated, YAML created
Comment 6 Felix Botner univentionstaff 2013-05-16 15:04:50 CEST
OK - errata3.1-1
OK - yaml

OK - ucs3.1-2
OK - changelog
Comment 7 Moritz Muehlenhoff univentionstaff 2013-05-22 16:09:55 CEST
http://errata.univention.de/ucs/3.1/102.html