Univention Bugzilla – Bug 31337
No visible feedback if form input is invalid
Last modified: 2013-07-19 18:05:45 CEST
This fix leads to a problem with the general validation of form elements. Upon validation, form elements are not anymore marked with a little exclamation mark to indicated that the chosen input is invalid. Workaround could be the following redefinition of umc/widgets/_FormWidgetMixin:validate(): validate: function() { var val = this.inherited(arguments); if (val === undefined) { return this.isValid(); } return val; } +++ This bug was initially created as a clone of Bug #30109 +++ A form.validate() iterates over all form widgets and validates them. This is done via widget.validate(). If this function is not found, the widget is silently skipped, producing Bugs like the cloned one. Every widget should implement a validate() function. At least PasswordInputBox and TimeBox lack this functionality. In general, Widgets that encapsulate dijit.form.Widgets through ContainerWidgets are prone to this error. In addition, the form.validate() function should not skip a widget without validate(), but instead fall back to isValid() and console.warn() the developer (if not throw an exception...). This way we can also handle future Widgets that forgot to implement the function. +++ This bug was initially created as a clone of Bug #30091 +++ * It is possible to set an empty password for new users. * It is not validated whether the first password matches the second. A red exclamation mark may appear but that does not prevent the form from being submitted. The first password input is chosen as the password.
*** Bug 31585 has been marked as a duplicate of this bug. ***
The patch has been applied. - ucs3.1-1 & YAML: univention-management-console-frontend (2.0.244-11) - ucs3.2-0 & Changelog: univention-management-console-frontend (2.0.257-1)
I found a validation problem which is UDM specific → Bug 31716 isValid() checks first whether an invalid state is forced (via the property "valid"). This should be done in validate(), as well (before calling its super method). If this is done, we should be able to remove _isValidSubset() in umc/widgets/_FormWidgetMixin as it does not seem to apply here. Its super method in dijit/form/ValidationTextBox respects the outcome of isValid. But this does not need to be done via this Bug.
As discussed, the behavior seems to be ok → Fixed
Erratum 3.1-1 changes: OK YAML file: OK UCS 3.2 changes: Please increase first version number of source package → FAIL changelog: OK All in all ok, only the debian changelog number needs to be increased.
(In reply to Alexander Kläser from comment #5) > All in all ok, only the debian changelog number needs to be increased. Done!
OK → VERIFIED
http://errata.univention.de/ucs/3.1/123.html
*** Bug 31716 has been marked as a duplicate of this bug. ***