Univention Bugzilla – Bug 32375
[Code cleanup] Inappropriate name of paramater "module" in hook.py#simpleHook methods
Last modified: 2017-11-01 13:49:18 CET
============================================ def hook_ldap_pre_create(self, module) def hook_ldap_addlist(self, module, al = []) def hook_ldap_post_create(self, module) def hook_ldap_pre_modify(self, module) def hook_ldap_modlist(self, module, ml = []) ^^^^^^ ============================================ Correctly, these functions don't get a reference to an UDM module passed, but a reference to an instance of it's object handler class. Hence, for reasons of comprehensibility, the "module" parameter should be called "object" instead. Should also be adapted in the developer documentation.
(In reply to Lukas Walter from comment #0) > ... > Hence, for reasons of comprehensibility, the "module" parameter should be > called "object" instead. Not exactly "object" as it is already defined in Python.
ucs-test (7.0.23-75) 3c44d7624092 | Bug #32375: Merge branch 'fbest/32375' into 4.2-2 fc068f490bc1 | Bug #32375: fix argument name: module → obj univention-directory-manager-modules (12.0.18-13) 3c44d7624092 | Bug #32375: Merge branch 'fbest/32375' into 4.2-2 fc068f490bc1 | Bug #32375: fix argument name: module → obj univention-directory-manager-modules.yaml 3c44d7624092 | Bug #32375: Merge branch 'fbest/32375' into 4.2-2 155a1b334bd3 | YAML Bug #32375
OK: errata-announce -V --only univention-directory-manager-modules.yaml FIXED: univention-directory-manager-modules.yaml → 602919ea99 OK: Jenkins OK: Code-Review OK: fc068f490bc1
<http://errata.software-univention.de/ucs/4.2/206.html>