Univention Bugzilla – Bug 36939
Only execute setup scripts belonging to the flavor
Last modified: 2014-12-04 12:22:59 CET
Created attachment 6459 [details] patch Currently when saving the Network settings, language settings, or certificate settings all system setup scripts are executed. This has several drawbacks: * progressbar messages are wrong * it is slow * some scripts are preventing a successful saving e.g. because no hostname is provided Only the scripts belonging to the flavor should be executed. Attached is a patch which does that.
patch has been applied.
Created attachment 6482 [details] Screenshot network settings page after applying the values has finished If I see correctly, the progress bar needs to be adapted in order to account for the correct number of scripts being executed (see screenshot). I spotted a minor thing, in setup.log I could not spot a __NAME___ line for the 10interfaces script. The patch bellow will fix that. Could you please apply it? --- usr/lib/univention-system-setup/scripts/30_net/10interfaces (Revision 56301) +++ usr/lib/univention-system-setup/scripts/30_net/10interfaces (Arbeitskopie) @@ -44,6 +44,7 @@ class NetworkSetup(SetupScript): + name = _("Configuring IPvX network interfaces") def __init__(self): super(NetworkSetup, self).__init__() @@ -55,7 +56,6 @@ def inner_run(self): self.parse_options() - self.name = _("Configuring IPvX network interfaces") self.setup_logging() self.setup_ud_logging() self.prepare_changeset()
*** Bug 36941 has been marked as a duplicate of this bug. ***
(In reply to Alexander Kläser from comment #2) > Created attachment 6482 [details] > Screenshot network settings page after applying the values has finished > > If I see correctly, the progress bar needs to be adapted in order to account > for the correct number of scripts being executed (see screenshot). fixed > I spotted a minor thing, in setup.log I could not spot a __NAME___ line for > the 10interfaces script. The patch bellow will fix that. Could you please > apply it? fixed
Looks fine now, also the full progress bar during the setup wizard looks good (well, it does not reach 100%, same as before). YAML entry is fine.
http://errata.univention.de/ucs/4.0/2.html