Bug 37711 - False positive "The following empty properties were set to default values in the form." notifications
False positive "The following empty properties were set to default values in ...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0-1-errata
Assigned To: Florian Best
Alexander Kläser
:
Depends on: 36700 37592
Blocks:
  Show dependency treegraph
 
Reported: 2015-02-06 11:06 CET by Janis Meybohm
Modified: 2015-02-24 08:25 CET (History)
8 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments
patch (1) (1.94 KB, patch)
2015-02-18 12:28 CET, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Janis Meybohm univentionstaff 2015-02-06 11:06:20 CET
+++ This bug was initially created as a clone of Bug #36700 +++

If I open a user without "Samba Account"-Option in UMC the following notification shows up (every time of cause as those values will never be set):
---
The following empty properties were set to default values in the form. These values will be applied when saving.
[Advanced settings] - Windows terminal server - CTX RAS Dialin: Disabled
[Advanced settings] - Windows terminal server - CTX Mirroring: Disabled
[Advanced settings] - Windows terminal server - Terminated or timed-out sessions: Disconnect
[Advanced settings] - Windows terminal server - Reconnect session: All Clients
---
Comment 1 Florian Best univentionstaff 2015-02-06 11:17:33 CET
Are the properties then displayed in UMC?
Comment 2 Philipp Hahn univentionstaff 2015-02-17 16:58:22 CET
This also happens for a "Simple Authentication Account" user: 
> The following empty properties were set to default values in the form. These values will be applied when saving.
> Account - Locking and deactivation - Account deactivation: None
> [Advanced settings] - Windows terminal server - CTX RAS Dialin: Disabled
> [Advanced settings] - Windows terminal server - CTX Mirroring: Disabled
> Groups - Primary group - Primary group: Backup Join
> [Advanced settings] - Windows terminal server - Terminated or timed-out sessions: Disconnect
> Account - Locking and deactivation - Locked login methods: None
> [Advanced settings] - Windows terminal server - Reconnect session: All Clients

As none of those options are available, the message is very confusing.

$ udm users/user create --option ldap_pwd --set username=test --set lastname=test --set password=univention
Comment 3 Florian Best univentionstaff 2015-02-17 16:59:29 CET
yes, probably we have to check if the widget is visible to fix it.
Comment 4 Janis Meybohm univentionstaff 2015-02-18 11:04:30 CET
(In reply to Philipp Hahn from comment #2)
> This also happens for a "Simple Authentication Account" user: 
And with other objects too (like shares for example if only one of NFS, Samba is activated.
Comment 5 Florian Best univentionstaff 2015-02-18 12:28:43 CET
Created attachment 6693 [details]
patch (1)

Here is a patch which excludes invisible widgets from being displayed in the error message (and don't display the message if all widgets are invisible).
I tested it with Philipps example.

The main problem still exists: detailpage.getAlteredValues() detects every combobox as altered because it does not have a value and is therefore set to the first available value... This causes btw. also other bugs like Bug #37532.
Comment 6 Florian Best univentionstaff 2015-02-19 11:04:22 CET
I've got a fully working patch now.
Comment 7 Florian Best univentionstaff 2015-02-19 11:26:27 CET
Fix: svn r58245
YAML: 2015-02-12-univention-management-console-module-udm.yaml
Comment 8 Alexander Kläser univentionstaff 2015-02-19 13:01:43 CET
Changes: OK, everything works smoothly, now (shares + users tested).
YAML file: OK

→ VERIFIED
Comment 9 Moritz Muehlenhoff univentionstaff 2015-02-24 08:25:10 CET
http://errata.univention.de/ucs/4.0/87.html