Bug 38330 - Query DNS configuration automatically via DHCP, as well
Query DNS configuration automatically via DHCP, as well
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Setup wizard
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0-2-errata
Assigned To: Alexander Kläser
Alexander Kramer
:
: 37938 38816 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-23 12:09 CEST by Alexander Kläser
Modified: 2015-07-16 14:24 CEST (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): External feedback, Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2015-04-23 12:09:56 CEST
We received the feedback that the DNS server needs to be configured manually when using DHCP. It would be nice to automatically use the DNS information sent via DHCP.
Comment 1 Alexander Kläser univentionstaff 2015-04-23 12:27:11 CEST
The DNS information can be accessed by JavaScript, and when querying DHCP information, this is already sent to JavaScript, as well, in the following format (executing on a VirtualBox VM):

  domainname: "knut.univention.de"
  is_ucs_nameserver_1: false
  nameserver_1: "10.0.3.3"
  nameserver_2: ""
  nameserver_3: ""
  gateway: "10.0.3.2"
  eth1_ip: "10.0.3.15"
  eth1_broadcast: "10.0.3.255"
  eth1_netmask: "255.255.255.0"

Currently, the code only uses the DHCP nameserver if it is a UCS nameserver. This logic should probably be adapted.
Comment 2 Florian Best univentionstaff 2015-04-23 12:33:24 CEST
(In reply to Alexander Kläser from comment #1)
> Currently, the code only uses the DHCP nameserver if it is a UCS nameserver.
> This logic should probably be adapted.
The code is btw. already used in the normal 'networks' module.
Comment 3 Alexander Kläser univentionstaff 2015-07-08 13:30:39 CEST
I made the following adjustments to address this issue + some related usability aspects:

* If DHCP is preconfigured and if no link local DHCP fallback address is set, an initial DHCP requests is sent right at the start of the setup wizard. This is needed in order to gain the DHCP nameserver address. As the requests will run in the background, the user will probably not notice it. If the requests still run when entering the network page, a spinning animation is shown until the requests are finished (similar to issuing a new DHCP request manually).

BTW... this adjustment also fixes Bug 37938.

* From the backend code I removed the check whether the DHCP nameserver is a UCS nameserver, as this will slow down the DHCP request and as this will by checked anyways when choosing to join into a UCS domain.

* As a usability goodie, I added a check that makes sure that the network settings are not applied a second time (when clicking 'next') if the have not changed (via comparing all widget values from the network page).


univention-system-setup (8.1.69-16):
r61873 | Bug #38330: Use DHCP nameserver if given

2015-07-03-univention-system-setup.yaml:
r61875 | Bug #38330: added YAML entry
Comment 4 Alexander Kläser univentionstaff 2015-07-08 13:31:04 CEST
*** Bug 37938 has been marked as a duplicate of this bug. ***
Comment 5 Florian Best univentionstaff 2015-07-08 13:34:45 CEST
*** Bug 38816 has been marked as a duplicate of this bug. ***
Comment 6 Alexander Kramer univentionstaff 2015-07-10 13:55:58 CEST
OK - initial DHCP requests
OK - removed the check whether the DHCP nameserver is a UCS nameserver
OK - makes sure that the network settings are not applied a second time

OK - debian/changelog

r62043
Adapted package nr for yaml file
Comment 7 Alexander Kramer univentionstaff 2015-07-13 12:41:58 CEST
(In reply to Alexander Kläser from comment #3)
> I made the following adjustments to address this issue + some related
> usability aspects:
> 
> * If DHCP is preconfigured and if no link local DHCP fallback address is
> set, an initial DHCP requests is sent right at the start of the setup
> wizard.

My system with a link local address (169.254.255.255) also triggers a initial DHCP request.
Comment 8 Alexander Kläser univentionstaff 2015-07-14 16:35:10 CEST
(In reply to Alexander Kramer from comment #7)
> My system with a link local address (169.254.255.255) also triggers a
> initial DHCP request.

Oops, I have overseen a JS return statement in the array.forEach() loop. Fixed.
Packages are building.

[UCS 4.0-2]
univention-system-setup (8.1.69-21):
r62106 | Bug #38330: adjust wrong return statement in ApplianceWizard method

[UCS 4.1-0]
univention-system-setup (8.1.69-21):
r62107 | Bug #38330: adjust wrong return statement in ApplianceWizard method
Comment 9 Alexander Kramer univentionstaff 2015-07-15 14:43:39 CEST
(In reply to Alexander Kramer from comment #6)
> OK - initial DHCP requests
> OK - removed the check whether the DHCP nameserver is a UCS nameserver
> OK - makes sure that the network settings are not applied a second time
> 
> OK - debian/changelog
> 
> r62043
> Adapted package nr for yaml file

OK - no initial request if a link local address is set
OK - also works with multiple interfaces

OK - debian/changelog 4.0-2
OK - yaml file 4.0-2

OK - changes merged to 4.1-0
OK - debian/changelog 4.1-0
Comment 10 Janek Walkenhorst univentionstaff 2015-07-16 14:24:39 CEST
<http://errata.univention.de/ucs/4.0/243.html>