Univention Bugzilla – Bug 38834
Remove user creation notification
Last modified: 2015-12-15 19:37:03 CET
After creating a user a notification is shown: 'user "username" created'. I think, we should remove this notification because the admin has just clicked on the create button. If the user couldn't be created, an error would have been shown.
It would be helpful to show such a note within the dialogue, so that the user is unsure whether or not the user has been created.
(In reply to Alexander Kläser from comment #1) > It would be helpful to show such a note within the dialogue, so that the > user is unsure whether or not the user has been created. I would prefer to remove the notification completely. Only in case of an error, a message should be shown.
(In reply to Stefan Gohmann from comment #2) > (In reply to Alexander Kläser from comment #1) > > It would be helpful to show such a note within the dialogue, so that the > > user is unsure whether or not the user has been created. > > I would prefer to remove the notification completely. Only in case of an > error, a message should be shown. IMHO it is not necessary to display a msg in case of an error. I tried: - stop slapd - stop univention server - stop univention web server - provide forbidden chars for the user name like !"? - use a password that is too short Everytime I already got an alert with a specific error msg. So no need for another Notfication. Do i miss something? Besides the error handler which raises the notification does not get a error object for every case listed above.
(In reply to Alexander Kramer from comment #3) > > I would prefer to remove the notification completely. Only in case of an > > error, a message should be shown. > > IMHO it is not necessary to display a msg in case of an error. I meant for example if the username is already used. But I guess an error message is already shown.
(In reply to Stefan Gohmann from comment #4) > I meant for example if the username is already used. But I guess an error > message is already shown. I came up with the same idea and tested it. And yes there is already an alert with the following msg: The LDAP object could not be saved: The username is already in use as username or as groupname : <Username>
Created attachment 7096 [details] Mockup: New notification if user is created I agree with both of you: During the usability studies we saw that the notifications were not as helpful as we thought. But I think it is important to give the user feedback, so just removing the notification won't improve the user experience. So what do you think about my suggestion? For me it is important to show a message where the user will see it immediately. BTW: Should we also adapt the notification for groups/computers/... ?
Created attachment 7097 [details] Patch: Remove user and computer create notification As requested I removed the notification. This patch will also effect the notification for a new computer object. (fyi: printers and groups does not use the wizard, so no notification is diaplayed anyway) If you want I can use this.moduleFlavor to add an exception for the creation notification for computers. But I think we should improve the notification there as well.
A new notification is displayed under the dialog, so the user will see it directly. The new notification disapears after a few secs. This patch effects the creation wizard for users and computers. FYI: Nothing has change for the error cases - the user still sees alerts and have enough time to read the information. ucs4.0-3 r63240 Successful build Package: univention-management-console-module-udm Version: 5.1.25-86.603.201508251224 Branch: ucs_4.0-0 Scope: errata4.0-3 yaml file r63244 ucs4.1-0 r63242 Successful build Package: univention-management-console-module-udm Version: 6.0.2-4.604.201508251238 Branch: ucs_4.1-0 Scope:
Not sure why but the animation still looks clumsy. Maybe a delay or deferred can fix this. Also getting an error for the onEnd function if the domNode does not exists: TypeError {stack: (...), message: "Cannot set property 'innerHTML' of undefined"}
(In reply to Alexander Kramer from comment #9) > Not sure why but the animation still looks clumsy. Maybe a delay or deferred > can fix this. > > Also getting an error for the onEnd function if the domNode does not exists: > > TypeError {stack: (...), message: "Cannot set property 'innerHTML' of > undefined"} Improved the look and feel of the animation and added a condition to check if a domNode exists before setting the textContent. ucs4.0-3 r 63304 Successful build Package: univention-management-console-module-udm Version: 5.1.25-88.608.201508281058 Branch: ucs_4.0-0 Scope: errata4.0-3 r63306 ucs4.1-0 r 63305 Successful build Package: univention-management-console-module-udm Version: 6.0.3-2.609.201508281104 Branch: ucs_4.1-0 Scope:
Please move the notification to the top. You can use this.addChild(foo, 0). Here are the modifications of the CSS styles: > margin-top: -1.6em; > margin-bottom: 1em; > color: rgb(60, 118, 61); > background-color: rgb(223, 240, 216);
(In reply to Florian Best from comment #11) > Please move the notification to the top. > You can use this.addChild(foo, 0). - done > Here are the modifications of the CSS styles: > > margin-top: -1.6em; > > margin-bottom: 1em; > > color: rgb(60, 118, 61); > > background-color: rgb(223, 240, 216); - done I also added a click listener so the user can close the notification. And I removed dojo/fx and used css transition instead. ucs 4.0-3 r 63446 fix and debian/changelog Successful build Package: univention-management-console-module-udm Version: 5.1.25-89.611.201509031505 Branch: ucs_4.0-0 Scope: errata4.0-3 ucs4.1-0 r 63447 fix and debian/changelog Successful build Package: univention-management-console-module-udm Version: 6.0.4-2.612.201509031521 Branch: ucs_4.1-0
r 63462 yaml file with adapted fix number
Fix: works, YAML: ~OK, Merge: OK
<http://errata.software-univention.de/ucs/4.0/354.html>