Univention Bugzilla – Bug 29900
[IE9] onclick in Update-Note is broken
Last modified: 2016-10-10 14:26:18 CEST
If UMC finds an Update, a note is shown in the overview: Note: An update for UCS is available. Please visit Online Update Module to install the updates. The link inside this note has some inline-JS: onclick="require(\'umc/app\').openModule(\'updater\')" I did not get this to work on IE 9, although the JS itself works: The module opens if I copy&paste it into the IE 9 development console.
Fun fact: If clicking on the link, the label of the overview-tab changes afterwards (to "true" or "false", depending on whether or not you clicked outside the overview-tab)
(In reply to comment #0) > ... > The link inside this note has some inline-JS: > onclick="require(\'umc/app\').openModule(\'updater\')" Shouldn't it be rather: onclick="require('umc/app').openModule('updater')" (In reply to comment #1) > Fun fact: If clicking on the link, the label of the overview-tab changes > afterwards (to "true" or "false", depending on whether or not you clicked > outside the overview-tab) Should it maybe then be something like: onclick="require('umc/app').openModule('updater'); return true;"
(In reply to comment #2) > Shouldn't it be rather: > > onclick="require('umc/app').openModule('updater')" > It is. I did not unescape the code. Version: 9.0.8112.16421 Updateversion: 9.0.1 (KB2530548) Windows 7 works fine, whilst Version: 9.0.8112.16421 Updateversion: 9.0.11 (KB2761451) Windows Server 2008 is broken.
(In reply to comment #3) > It is. I did not unescape the code. > > Version: 9.0.8112.16421 > Updateversion: 9.0.1 (KB2530548) > Windows 7 > > works fine, whilst > > Version: 9.0.8112.16421 > Updateversion: 9.0.11 (KB2761451) > Windows Server 2008 > > is broken. Hm… I noticed also other problems with the IE-Version on Windows Server 2008 (e.g., see Bug 27414). Is this problem eventually fixed with a newer version of IE or a service pack update?
The link works fine with a new IE 9 installed on Windows 7 Version: 9.0.8112.16421 Updateversion: 9.0.12 (KB2761465) Windows 7 This seems to be a problem with a (probably not up-to-date) Windows Server 2008 installation. See also Bug#28498 - Dojo 1.7+ uses the native JSON implementation of the OS. This caused a Bug on old (not updated) Windows installations (seen on Windows XP and Windows Vista). I would rather close this bug as WONTFIX instead of digging into the Dojo code just to find out that a Windows update would have solved the problem.
(In reply to comment #5) > The link works fine with a new IE 9 installed on Windows 7 > > Version: 9.0.8112.16421 > Updateversion: 9.0.12 (KB2761465) > Windows 7 > > This seems to be a problem with a (probably not up-to-date) Windows Server 2008 > installation. Have you tried it on an updated 2008 system?
(In reply to comment #6) > (In reply to comment #5) > > The link works fine with a new IE 9 installed on Windows 7 > > > > Version: 9.0.8112.16421 > > Updateversion: 9.0.12 (KB2761465) > > Windows 7 > > > > This seems to be a problem with a (probably not up-to-date) Windows Server 2008 > > installation. > > Have you tried it on an updated 2008 system? Not yet (I may not update the system), but the system was relatively new. The link works in the Windows 2008 - FF though... The problem has nothing to do with require('umc/app').openModule('updater') itself. The link added with the fix for Bug#26507 does not work either.
Putting the code directly in javascript works slightly better: This <a href="javascript:require(\'umc/app\').openModule(\'updater\')">works</a>. At least the module is opened. But after that only the focused tab has a title. There is something seriously wrong with Windows Server 2008's IE 9.
(In reply to comment #8) > Putting the code directly in javascript works slightly better: > > This <a > href="javascript:require(\'umc/app\').openModule(\'updater\')">works</a>. > > At least the module is opened. But after that only the focused tab has a title. > There is something seriously wrong with Windows Server 2008's IE 9. Windows Server 2008 was updated, restarted. The behaviour changed a bit. The module is still opened, titles for both tabs (overview, updater) are shown. If you click on the overview tab again the title "Overview" vanishes! This sounds like arbitrary code execution. I am not sure if this can be fixed. Using onclick does not work at all.
(In reply to comment #9) > (In reply to comment #8) > > Putting the code directly in javascript works slightly better: > > > > This <a > > href="javascript:require(\'umc/app\').openModule(\'updater\')">works</a>. > > > > At least the module is opened. But after that only the focused tab has a title. > > There is something seriously wrong with Windows Server 2008's IE 9. > > Windows Server 2008 was updated, restarted. The behaviour changed a bit. The > module is still opened, titles for both tabs (overview, updater) are shown. If > you click on the overview tab again the title "Overview" vanishes! This sounds > like arbitrary code execution. I am not sure if this can be fixed. > > Using onclick does not work at all. I see as address javascript:void(0) and not the openModule() command. Is this correct?
The links that refer to the policies work with Win 2008, the Administrator link does not. See also umc/modules/udm/DetailPage.js +839, maybe there is a difference in setting the value?
(In reply to comment #11) > The links that refer to the policies work with Win 2008 Not really. The policy-module opens, but the tab is set 'disabled' (I did not know that this is possible...). Somehow the title code is somehow interfering with other code.
(In reply to comment #10) > I see as address javascript:void(0) and not the openModule() command. Is this > correct? Yes, this was just a test. javascript:void(0) is what we do normally. I changed it locally because of curiosity.
This is probably an external issue. There seem to be some RDP interferences together with some (OS-) user privileges. I repeat what I said before: I do not think we should fix this. The code itself seems to be correct. But if we really want to try, univention-management-console-module-apps has a helper function _AnchorButton. At least this module does not suffer from this bug in my Windows Server 2008 IE 9 session. But will this really solve all issues on the platform when connected via rdesktop?
We should wait and see if the problem occurs in other environments.
*** Bug 32700 has been marked as a duplicate of this bug. ***
(In reply to Stefan Gohmann from comment #15) > We should wait and see if the problem occurs in other environments. Since it happened again → 3.2-x.
Still reproducible?
IE9 is not supported anymore.