Univention Bugzilla – Bug 31074
Check for obsolete UCR variables in Univention Updater
Last modified: 2021-05-25 16:02:56 CEST
The UCR variable repository/online/hotfixes still seems to get set on UCS 3.x systems. Guessing from the name it seems to be obsolete?
update/umc/nextversion?true gets set in the postinst. It was introduced in Bug 14302, but in the current UCS 3.2 it isn't used anywhere.
update/custom/preup and update/custom/postup are currently preset to non-existing files in postinst: update/custom/preup?/var/lib/local-preup.sh \ update/custom/postup?/var/lib/local-postup.sh \ This doesn't cause harm since preup.sh tests whether the content of the variables is an executable shell script, but it's irritating and should not be set by default.
update/doc/releasenotes/url and update/doc/releasenotes/description are set to http://download.univention.de/doc/ in postinst, but not used anywhere. update/check/cron/debug and update/check/boot/debug are named incorrect; activating them _prevents_ additional debug. IMO the variables can simply be removed.
(In reply to Moritz Muehlenhoff from comment #3) > update/check/cron/debug and update/check/boot/debug are named incorrect; > activating them _prevents_ additional debug. IMO the variables can simply be > removed. You missed the 'not' between the 'if' and 'ucr.get()': > if *not* configRegistry.get('update/check/cron/debug','no').lower() in ('yes','true','enabled','1','2','3','4'): > debug = '2> /dev/null > /dev/null' If it is not removed, it should be changed at least to disables = '#' if ucs.is_false('update/check/cron/enabled', True) or '' debug = '2>/dev/null" if ucr.is_false('update/check/cron/debug', True) or '' Mind that this is not 100% equivalent, because setting the URCV to 'some other value', which is neither 1/yes/on/... nor 0/no/off/... would have a different result.
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4. If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
(In reply to Arvid Requate from comment #0) > The UCR variable repository/online/hotfixes still seems to get set on UCS > 3.x systems. Guessing from the name it seems to be obsolete? commit e77f1572c1a877ee456bf0648f900a21a62d11d3 Author: Philipp Hahn <hahn@univention.de> Date: Wed Jun 13 09:34:07 2018 +0200 Bug #36719 up: Remove deprecated UCS-2.x code (In reply to Moritz Muehlenhoff from comment #3) > update/doc/releasenotes/url and update/doc/releasenotes/description are set > to http://download.univention.de/doc/ in postinst, but not used anywhere. commit cfa4d4b4837ae80e543b170f59925f462beed1d4 Author: Philipp Hahn <hahn@univention.de> Date: Wed Oct 21 14:31:51 2015 +0000 Bug #39306 updater: Switch external URLs to https:// Remove obsolete UCR variables update/doc/releasenotes/*.
Created attachment 9789 [details] Drop old UCR variables
The UCRV were removed with git:a6b5996b1f03e72e5df1566e990c7bce3567f8fe as part of the work to convert univention-updater to Python 3 *** This bug has been marked as a duplicate of bug 51588 ***
Please note that UCRV update/custom/{pre,post}up are still used in base/univention-updater/script/{pre,post}up.sh, but setting them to a non-existing script is pointless and confusing.
repository/online/hotfixes -> has been removed with bug 30943 update/doc/releasenotes/url & update/doc/releasenotes/description -> have been removed with bug 39306 update/umc/nextversion not used any more -> OK update/umc/nextversion not set any more -> OK update/umc/nextversion marked as deprecated -> OK update/custom/{pre,post}up not set any more but not deprecated -> OK -> Verified
UCS 5.0 has been released: https://docs.software-univention.de/release-notes-5.0-0-en.html https://docs.software-univention.de/release-notes-5.0-0-de.html If this error occurs again, please use "Clone This Bug".