Bug 33496 - Call join scripts after app installation
Call join scripts after app installation
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 3.2
Other Linux
: P5 enhancement (vote)
: ---
Assigned To: UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-20 18:03 CET by Alexander Kläser
Modified: 2013-12-30 09:39 CET (History)
5 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2013-11-20 18:03:53 CET
It can be confusing that join scripts need to be executed after the installation of an app. The execution of univention-run-join-scripts could at least be tried with the given user credentials. If that fails, a proper hint (maybe with a link to the join module) could help to understand that join scripts need to be executed.
Comment 1 Alexander Kläser univentionstaff 2013-11-20 18:07:01 CET
*** Bug 33462 has been marked as a duplicate of this bug. ***
Comment 2 Florian Best univentionstaff 2013-11-21 08:06:46 CET
Or asking for credentials (if the permissions aren't enough) like it is done in system-setup and join module.
Comment 3 Dirk Wiesenthal univentionstaff 2013-11-21 11:47:51 CET
If it is done this way, all pending join scripts will be called.

A similar situation is considered problematic: All errata updates are installed when updating an app.
Comment 4 Florian Best univentionstaff 2013-11-21 14:03:34 CET
(In reply to Dirk Wiesenthal from comment #3)
> If it is done this way, all pending join scripts will be called.
> 
> A similar situation is considered problematic: All errata updates are
> installed when updating an app.

No, you can give the joinscripts you want to execute as parameter to univention-run-join-scripts.
Comment 5 Dirk Wiesenthal univentionstaff 2013-11-21 14:13:08 CET
(In reply to Florian Best from comment #4)
> No, you can give the joinscripts you want to execute as parameter to
> univention-run-join-scripts.

And how do I know which joinscripts are to be run? Everything that starts with ${appid}?
Comment 6 Erik Damrose univentionstaff 2013-11-21 15:21:58 CET
dpkg knows which files are installed by a package. Just look what was placed in /usr/lib/univention-install/

dpkg-query -L <packagename>
Comment 7 Dirk Wiesenthal univentionstaff 2013-11-21 17:09:56 CET
(In reply to Erik Damrose from comment #6)
> dpkg knows which files are installed by a package. Just look what was placed
> in /usr/lib/univention-install/
> 
> dpkg-query -L <packagename>

Maybe this works (I would need python bindings for that, though). But still I need to know which packages are newly installed (plus all dependencies). But not all packages that apt tells me: I still have to differentiate between those that are actually installed and those that are only updated.
...
Except an updated version of that package brings a new join script, of course... Maybe I monitor the whole directory? Then I need to parse "VERSION=x"...

Sounds feasible. Smells hacky.
Comment 8 Dirk Wiesenthal univentionstaff 2013-11-21 17:21:21 CET
Best approach in my opinion:

If new modules show up without relogin (see Bug#33202), there would be no "Restart required" dialogue after app installation -> Issue a "join/check_join_status" command, show result as dialog.notify() (just like after login).

Alternatively:
  Run check-join-status before app installation!
    If everything run:
      check-join-status after app installation!
        If something is missing:
          run-join-scripts with user credentials
And even this is not really correct (join status changed due to other reasons)
Comment 9 Stefan Gohmann univentionstaff 2013-11-21 20:23:46 CET
I would prefer WONTFIX. After the App has been installed the admin gets the notification about the missing join script. Once the restart popup has been removed, it gets straightforward.

I think we should improve the domain join module, for example Bug #33528.
Comment 10 Stefan Gohmann univentionstaff 2013-12-30 09:39:36 CET
(In reply to Stefan Gohmann from comment #9)
> I would prefer WONTFIX. After the App has been installed the admin gets the
> notification about the missing join script. Once the restart popup has been
> removed, it gets straightforward.
> 
> I think we should improve the domain join module, for example Bug #33528.

→ WONTFIX