Bug 34473 - Don't list non-samba groups in primary group fields of a samba user
Don't list non-samba groups in primary group fields of a samba user
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: UMC - Users
UCS 3.2
Other Linux
: P5 normal (vote)
: UCS 3.2-x
Assigned To: UMC maintainers
:
: 29679 34525 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-04 09:13 CEST by Janis Meybohm
Modified: 2017-08-08 07:11 CEST (History)
5 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Error handling, Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janis Meybohm univentionstaff 2014-04-04 09:13:45 CEST
Ticket#2014040421000778

The primary group of samba user has to be a samba group. If a non-samba group is selected, UMC shows the following traceback:
---
  File "/usr/lib/pymodules/python2.6/notifier/threads.py", line 82, in _run
    tmp = self._function()
  File "/usr/lib/pymodules/python2.6/notifier/__init__.py", line 104, in __call__
    return self._function( *tmp, **self._kwargs )
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/udm/__init__.py", line 377, in _thread
    module.modify( properties )
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/udm/udm_ldap.py", line 155, in wrapper_func
    ret = func( *args, **kwargs )
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/udm/udm_ldap.py", line 410, in modify
    obj.modify()
  File "/usr/lib/pymodules/python2.6/univention/admin/handlers/__init__.py", line 345, in modify
    return self._modify(modify_childs,ignore_license=ignore_license)
  File "/usr/lib/pymodules/python2.6/univention/admin/handlers/__init__.py", line 922, in _modify
    self._ldap_post_modify()
  File "/usr/lib/pymodules/python2.6/univention/admin/handlers/users/user.py", line 1857, in _ldap_post_modify
    self.__primary_group()
  File "/usr/lib/pymodules/python2.6/univention/admin/handlers/users/user.py", line 1676, in __primary_group
    primaryGroupSambaNumber = number['sambaSID']

KeyError: 'sambaSID'
---


The primary group field of samba users should only list "compatible" groups to avoid this. In addition, a helpful error message should be displayed when CLI is used.
Comment 1 Dirk Wiesenthal univentionstaff 2014-04-10 13:15:41 CEST
*** Bug 29679 has been marked as a duplicate of this bug. ***
Comment 2 Dirk Wiesenthal univentionstaff 2014-04-10 13:15:55 CEST
*** Bug 34525 has been marked as a duplicate of this bug. ***
Comment 3 Stefan Gohmann univentionstaff 2017-06-16 20:36:51 CEST
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4.

If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
Comment 4 Florian Best univentionstaff 2017-06-28 14:52:52 CEST
There is a Customer ID set so I set the flag "Enterprise Customer affected".
Comment 5 Stefan Gohmann univentionstaff 2017-08-08 07:11:18 CEST
This issue has been filed against UCS 3.2.

UCS 3.2 is out of maintenance and many UCS components have vastly changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen this issue. In this case please provide detailed information on how this issue is affecting you.