Bug 34546 - univention-pam: Code cleanup for pam/common-*, bug in auth-nowrite
univention-pam: Code cleanup for pam/common-*, bug in auth-nowrite
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: PAM
UCS 3.2
All Linux
: P5 normal (vote)
: UCS 3.x
Assigned To: UCS maintainers
:
Depends on: 30036
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-15 08:57 CEST by Philipp Hahn
Modified: 2018-04-13 13:42 CEST (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:
hahn: Patch_Available+


Attachments
conffiles/etc/pam.d/common-* (20.00 KB, application/x-tar)
2014-04-15 08:57 CEST, Philipp Hahn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2014-04-15 08:57:08 CEST
Created attachment 5871 [details]
conffiles/etc/pam.d/common-*

+++ This bug was initially created as a clone of Bug #30036 +++
The pam/common-* files are currently hard to read, as the current code does tricky tricks with index to determine the last entry in the PAM stack. During the work on Bug #34315 I tried to understand the code and generated the following clean-ed up files:
  conffiles/etc/pam.d/common-account
  conffiles/etc/pam.d/common-auth-nowrite
  conffiles/etc/pam.d/common-auth.d/50univention-pam_general
  conffiles/etc/pam.d/common-password
For all expect "auth-nowrite" there is a regression test since r49335 to assert no change in behaviour.
"auth-nowrite" actually has a bug and get the "required" for the last module right, when auth/methods does not include 'cache'.
Comment 1 Stefan Gohmann univentionstaff 2017-06-16 20:38:25 CEST
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4.

If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
Comment 2 Stefan Gohmann univentionstaff 2017-08-08 07:11:34 CEST
This issue has been filed against UCS 3.2.

UCS 3.2 is out of maintenance and many UCS components have vastly changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen this issue. In this case please provide detailed information on how this issue is affecting you.