Bug 35198 – App Center should use ucr_update in set_save_commit_load

Bug 35198 - App Center should use ucr_update in set_save_commit_load


Summary:	App Center should use ucr_update in set_save_commit_load

Status:	RESOLVED DUPLICATE of bug 40064

Product:	UCS
Classification:	Unclassified
Component:	UMC - App-Center
Version:	UCS 3.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 3.2-x
Assigned To:	UMC maintainers
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-25 14:53 CEST by Dirk Wiesenthal
Modified:	2016-04-19 09:22 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Cleanup
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2014-06-25 14:53:57 CEST

Currently it is:

def set_save_commit_load(ucr):
	ucr.load()
	changes = Changes(ucr)
	yield changes
	ucr.save()
	ucr.load()
	if changes.changed():
		changes.commit()

We should get rid of save() and use ucr_update in commit() - instead of univention.config_registry.configHandlers().__call__

Comment 1 Alexander Kläser

2014-06-25 16:59:37 CEST

Not sure whether the current handling may cause problems on systems in particular cases...

Comment 2 Florian Best

2016-04-19 09:22:43 CEST

Would not be anymore relevant when Bug #40064 is fixed.

*** This bug has been marked as a duplicate of bug 40064 ***