Bug 36755 - pdbedit (password history) broken in samba4 rc2
pdbedit (password history) broken in samba4 rc2
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Samba
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0
Assigned To: Arvid Requate
Felix Botner
https://bugzilla.samba.org/show_bug.c...
: interim-4
Depends on:
Blocks: 37018
  Show dependency treegraph
 
Reported: 2014-11-17 14:50 CET by Felix Botner
Modified: 2014-11-26 07:09 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2014-11-17 14:50:23 CET
UCS 4.0 univention-samba

https://groups.google.com/forum/#!topic/mailing.unix.samba/bwvhW6hnvrs

If i configure the passwordHistory

-> udm settings/sambadomain modify \
   --dn sambaDomainName=FB,cn=samba,dc=fb,dc=test \
   --set passwordHistory=3

or
-> pdbedit -P "password history" -C 3

samba no longer finds user objects.

-> pdbedit  -Lv fb1
pdb_set_pw_history: data_blob_talloc() failed!
Username not found!

-> smbclient  //master/fb1 -U fb1%univention
Domain=[FB] OS=[Windows 6.1] Server=[Samba 4.2.0rc2-Debian]
tree connect failed: NT_STATUS_ACCESS_DENIED

The only way to "repair" this, is to remove the password history

-> pdbedit -P "password history" -C 0 

Setting the password history via UDM (to 0) does not help!
Comment 1 Arvid Requate univentionstaff 2014-11-17 16:20:52 CET
As Felix pointed out there has been some change recently in that fuction:

https://lists.samba.org/archive/samba-technical/2014-September/102319.html

Since data_blob_talloc doesn't return a pointer but a DATA_BLOB value, it's not a good idea to free the saved pointer.
Comment 2 Arvid Requate univentionstaff 2014-11-17 17:20:03 CET
pdbedit works again after reverting the patch. Changelog not required.
I filed an upstream bug report for this, see URL.
Comment 3 Felix Botner univentionstaff 2014-11-18 11:18:35 CET
OK
Comment 4 Stefan Gohmann univentionstaff 2014-11-26 06:54:36 CET
UCS 4.0-0 has been released:
 http://docs.univention.de/release-notes-4.0-0-en.html
 http://docs.univention.de/release-notes-4.0-0-de.html

If this error occurs again, please use "Clone This Bug".