Bug 39228 - Make Computerroom module SAML ready
Make Computerroom module SAML ready
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room
UCS@school 4.1
Other Linux
: P5 normal (vote)
: UCS@school 4.1
Assigned To: Florian Best
Sönke Schwardt-Krummrich
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-20 10:18 CEST by Florian Best
Modified: 2016-01-11 11:15 CET (History)
0 users

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2015-08-20 10:18:17 CEST
The computerroom module should be adjusted to work with the new SAML authentication.

It currently sets credentials at the italc core:
>               italc.ItalcCore.authenticationCredentials.setLogonUsername( username )
>               italc.ItalcCore.authenticationCredentials.setLogonPassword( password )

This should not be necessary as the communication to italc happens via public+privatekey:
> italc.ItalcCore.config.setLogonAuthenticationEnabled( False )
> italc.ItalcCore.setRole( italc.ItalcCore.RoleTeacher )
> italc.ItalcCore.initAuthentication( italc.AuthenticationCredentials.PrivateKey )
Comment 1 Florian Best univentionstaff 2015-08-20 11:46:37 CEST
Yes, it seems everything still works when removing the 2 lines.
Comment 2 Florian Best univentionstaff 2015-10-14 17:59:56 CEST
(In reply to Florian Best from comment #1)
> Yes, it seems everything still works when removing the 2 lines.
The two lines have been removed as well as in the debugging scripts.

ucs-school-umc-computerroom (7.0.0-2):
r64451 | Bug #39228: don't set credentials in italc due to SAML login
r64442 | Bug #39228: don't set credentials in italc due to SAML login
Comment 3 Sönke Schwardt-Krummrich univentionstaff 2015-11-16 23:36:38 CET
(In reply to Florian Best from comment #1)
> Yes, it seems everything still works when removing the 2 lines.
→ ACK

OK: Code change
OK: functional check
OK: xml changelog
Comment 4 Florian Best univentionstaff 2016-01-11 11:15:33 CET
UCS@school 4.1 has been released:
http://docs.software-univention.de/release-notes-ucsschool-4.1v1-de.html

If this error occurs again, please use "Clone This Bug".