Bug 39444 - cleanup UCR module API
cleanup UCR module API
Status: RESOLVED DUPLICATE of bug 30127
Product: UCS
Classification: Unclassified
Component: UCR
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-x
Assigned To: UCS maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-09-30 13:12 CEST by Florian Best
Modified: 2020-07-06 15:38 CEST (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup, Error handling
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2015-09-30 13:12:11 CEST
The handler(ucr, changes) function of a UCR module have is called differently:
If the handler is called when changing variables: the "changes" parameter might be a dict of tuples containing (old, new).

But the handler is also called on every postinst / ucr register which calls the handler with different arguments:
"changes" is a dict of strings with the actual values in that case.

Instead of this broken API we should either unify the arguments or add another function which is called "register".
Comment 1 Stefan Gohmann univentionstaff 2019-01-03 07:18:48 CET
This issue has been filled against UCS 4.1. The maintenance with bug and security fixes for UCS 4.1 has ended on 5st of April 2018.

Customers still on UCS 4.1 are encouraged to update to UCS 4.3. Please contact
your partner or Univention for any questions.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or simply reopen the issue. In this case please provide detailed information on how this issue is affecting you.
Comment 2 Florian Best univentionstaff 2020-07-06 15:38:12 CEST

*** This bug has been marked as a duplicate of bug 30127 ***