Univention Bugzilla – Bug 41933
85_ucs-translation-template.00_fuzzy_entries_on_merge.test fails
Last modified: 2020-03-30 17:12:32 CEST
The test currently fails, see also: http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-3/job/AutotestJoin/5/SambaVersion=s3,Systemrolle=master/testReport/85_ucs-translation-template/00_fuzzy_entries_on_merge/test/ Could you check what exactly the problem is? I would guess that it is an edge case that has not been considered yet.
I've disabled the test case. Please re-enable the test case once the issue has been fixed. Part of r71476 01_merge_new_module is now skipped in AD member mode: http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-3/job/ADMemberMultiEnv/2/Mode=installation,Version=w2k12r2-france/testReport/junit/85_ucs-translation-template/01_merge_new_module/test/
Created attachment 7865 [details] WIP patch The attached patch fixes a corner case in which _change_entry_in_source_file() would fail silently resulting in the issue seen in comment #1. It appears when _() is used with multi-line strings, e.g.: foo = _('long foobar text \ rest of foobar text') I could not yet determine what is causing the issue in comment #2.
Rev. 71620: * 01_merge_new_module: Fix issue with multi-line strings * Only execute tests on master as they are role independent Package: ucs-test Version: 6.0.36-6.1527.201608151915
Upon further review I see that this needs to be done lexically correct with a tokenizer or a at least fail safe, thus I am reopening.
Current jenkins test fails: http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-3/job/AutotestJoin/SambaVersion=s3,Systemrolle=master/lastCompletedBuild/testReport/85_ucs-translation-template/00_fuzzy_entries_on_merge/test/
Rev. 71687: Deactivated again until proposed changes are implemented. Package: ucs-test Version: 6.0.36-8.1529.201608171655
The test still references SVN: <http://forge.univention.org/svn/dev/branches/ucs-4.1/ucs-4.1-1/management> We switched to GIT: <https://github.com/univention/univention-corporate-server>
bin:ucs-test-translation-template contains two tests, which are both tagged SKIP and still reference SVN, which is not used since UCS-4.1 I removed bin:ucs-test-translation-template and the dependency for now. [4.4-4] b62da0f18a Bug #41933 ucs-test: Remove translation-template test/ucs-test/debian/control | 12 - .../debian/ucs-test-translation-template.install | 1 - .../00_fuzzy_entries_on_merge | 147 ------------ .../01_merge_new_module | 89 -------- ...univention-management-console-module-dummy.inst | 51 ----- ...ion-management-console-module-dummy.umc-modules | 6 - .../umc/de.po | 22 -- .../umc/dummy.xml | 14 -- .../umc/js/de.po | 110 --------- .../umc/js/dummy.js | 248 --------------------- .../umc/js/dummy/DetailPage.js | 164 -------------- .../umc/python/dummy/__init__.py | 114 ---------- .../umc/python/dummy/de.po | 17 -- .../tests/85_ucs-translation-template/tools.py | 62 ------ 14 files changed, 1057 deletions(-) Also base/univention-system-activation/debian/control wrongly build-dependends on bin:ucs-test-translation-template, which should be 'bin:univention-ucs-translation-template' instead. (the later is installed by the former through a chain of inter-package-dependencies). [4.4-4] 1b9e7a9fb4 Bug #41933 system-activation: Fix build dependency base/univention-system-activation/debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)