Bug 43389 - UCS@school: enhance UMCConnection
UCS@school: enhance UMCConnection
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC
UCS@school 4.2
Other Linux
: P5 enhancement (vote)
: UCS@school 4.2 v1
Assigned To: Florian Best
Daniel Tröder
:
: 43711 43718 (view as bug list)
Depends on:
Blocks: 38720 39731
  Show dependency treegraph
 
Reported: 2017-01-20 18:44 CET by Florian Best
Modified: 2017-04-11 17:45 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
patch (11.60 KB, patch)
2017-01-20 18:44 CET, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2017-01-20 18:44:51 CET
Created attachment 8361 [details]
patch

Fixes for UMCConnection in UCS@school.

The UCS 4.2 branch doesn't exists yet, so here is a patch.

+++ This bug was initially created as a clone of Bug #34498 +++

For a test case it was necessary to get the result of a UMCP request which does not return JSON (instead returns a PDF file).

With the current API this is not possible because the response mimetype is not checked. JSON is always assumed.

There is also no possibility to get the response headers which is necessary for the test script, too.
Comment 1 Florian Best univentionstaff 2017-01-23 20:17:22 CET
Use a copy of the current version in UCS@school Tests.

ucs-test-ucsschool (3.0.17-48):
r76032 | Bug #43389: use univention.lib.umc.Client
r76031 | Bug #43389: use univention.lib.umc.Client
Comment 2 Florian Best univentionstaff 2017-02-17 15:59:14 CET
ucs-school-umc-installer (5.0.0-1):
r76783 | Bug #43389: use univention.lib.umc.Client

ucs-test-ucsschool (4.0.0-1):
r76785 | Bug #43389: use univention.lib.umc.Client

ucs-school-umc-exam (7.0.0-1):
r76784 | Bug #43389: use univention.lib.umc.Client
Comment 3 Florian Best univentionstaff 2017-03-03 13:03:17 CET
*** Bug 43711 has been marked as a duplicate of this bug. ***
Comment 4 Florian Best univentionstaff 2017-03-03 18:17:22 CET
*** Bug 43718 has been marked as a duplicate of this bug. ***
Comment 5 Daniel Tröder univentionstaff 2017-03-13 15:15:29 CET
Changes were done to UCS@school 4.1 R2 and UCS@school 4.2 v1.

(In reply to Florian Best from comment #2)
> ucs-school-umc-installer (5.0.0-1):
OK: Package was extensively tested as part of QA for Bug #42905.

> ucs-test-ucsschool (4.0.0-1):
OK: Package ucs-test-ucsschool imports and auth() were migrated to new umc lib.
OK: tested random samples of test suite

> ucs-school-umc-exam (7.0.0-1):
OK: manual test
OK: automated tests:
11_squidguard_assign_rule_to_2_rooms 21_computerroom_module_base_checks 22_computerroom_module_settings 22_computerroom_test_printmode_ucr_variables 22_computerroom_time_settings 25_room_management_module 101_exam_mode  101_exam_mode_group_members  101_exam_mode_home_directories  101_exam_mode_settings
Comment 6 Sönke Schwardt-Krummrich univentionstaff 2017-04-11 17:45:40 CEST
UCS@school 4.2 v1 has been released.

http://docs.software-univention.de/release-notes-ucsschool-4.2v1-de.html

If this error occurs again, please clone this bug.