Bug 43759 – Cleanup usr/lib/univention-system-setup/scripts/setup_utils.sh

Bug 43759 - Cleanup usr/lib/univention-system-setup/scripts/setup_utils.sh


Summary:	Cleanup usr/lib/univention-system-setup/scripts/setup_utils.sh

Status:	NEW

Product:	UCS
Classification:	Unclassified
Component:	System setup
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	UCS maintainers
QA Contact:	UCS maintainers

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-03-09 09:28 CET by Philipp Hahn
Modified:	2020-07-02 10:27 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Cleanup
Max CVSS v3 score:

Flags:	hahn: Patch_Available+

Attachments
Fix shell issues (2.99 KB, patch) 2017-03-09 09:28 CET, Philipp Hahn	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Philipp Hahn

2017-03-09 09:28:45 CET

Created attachment 8507 [details]
Fix shell issues

Don't clobber variables - use local
Reduce number of forked sub processes - no need for echo `` expect to strip trailing white-space, but as all 3 callers use var=`` anyway, it's usless.
Fix handling of long DNs - missing ldapsearch-wrap
Use case statement - no need to evaluate variables multiple times