Bug 43991 – UMC App Center shows HTML entities in Dialog

Bug 43991 - UMC App Center shows HTML entities in Dialog


Summary:	UMC App Center shows HTML entities in Dialog

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - App-Center
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.2
Assigned To:	Florian Best
QA Contact:	Dirk Wiesenthal

URL:
Keywords:	interim-4

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-03-21 01:41 CET by Dirk Wiesenthal
Modified:	2017-04-04 18:29 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Escaped App name (31.30 KB, image/png) 2017-03-21 01:41 CET, Dirk Wiesenthal	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2017-03-21 01:41:10 CET

Created attachment 8598 [details]
Escaped App name

When installing Nagios, the title is "Netzwerküberwachung (Nagios)"

But the headline inside reads "Installation von Netz&shy;werk&shy;&uuml;ber&shy;wa&shy;chung (Nagios)"

Comment 1 Florian Best

2017-03-21 19:39:11 CET

Where does these chars come from? Are they set like this in the ini file?

Comment 2 Dirk Wiesenthal

2017-03-22 02:10:27 CET

Yes, this is the Name= attribute in [de]:
  http://appcenter-test.software-univention.de/meta-inf/4.2/nagios/nagios.ini

Comment 3 Florian Best

2017-03-23 15:05:35 CET

univention-appcenter (6.0.4-1):
r78207 | Bug #43991: fix and siplify the encoding of HTML entities

Comment 4 Dirk Wiesenthal

2017-03-27 13:18:58 CEST

Now Nagios is shown correctly.


But I think this is still wrong, at least inconsistent. HTML in Name= is interpreted in the Gallery. But escaped in the title of the DetailsPage.

We should try to escape it in the Gallery, too? Just make sure that the shy-characters in Nagios' name can be used.

Comment 5 Florian Best

2017-03-27 13:51:58 CEST

Yes, escape also in the AppGallery.

univention-appcenter (6.0.6-1):
r78351 | Bug #43991: correctly html escape all gallery item contents

univention-web (1.0.41-1):
r78351 | Bug #43991: correctly html escape all gallery item contents

Comment 6 Dirk Wiesenthal

2017-03-28 11:23:57 CEST

Works

Comment 7 Stefan Gohmann

2017-04-04 18:29:20 CEST

UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".