Bug 44056 - Errors in packetfilter.d/20_docker.sh during upgrade
Errors in packetfilter.d/20_docker.sh during upgrade
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: Docker
UCS 4.2
Other Linux
: P5 normal (vote)
: ---
Assigned To: App Center maintainers
App Center maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-03-23 18:41 CET by Janek Walkenhorst
Modified: 2020-07-03 20:51 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janek Walkenhorst univentionstaff 2017-03-23 18:41:18 CET
univention-firewall provides
 /etc/univention/templates/files/etc/security/packetfilter.d/20_docker.sh
but does not depend on (u-)docker
As such during the upgrade
 Stopping Univention iptables configuration::.
 Starting Univention iptables configuration::Error response from daemon: client and server don't have same version (client : 1.24, server: 1.18).

This can also be a problem in general during the installation of u-firewall without docker (already configured).

I think
 /etc/univention/templates/files/etc/security/packetfilter.d/20_docker.sh
should be provided by u-docker instead of u-firewall; Isn't that what ".d"-directories are for?

Alternatively the 20_docker.sh needs to check if docker is available and correctly responding before using (the output of) docker.

This also highlights the missing error checking in:
 for CONT_ID in $(docker ps -q); do
Comment 1 Janek Walkenhorst univentionstaff 2017-03-23 18:46:28 CET
I think
 20_docker.sh
is also responsible for
 Starting Univention iptables configuration...Failed to get D-Bus connection: Unbekannter Fehler -1
but it might already be fixed with r78226/Bug #44033
Comment 2 Daniel Tröder univentionstaff 2017-03-24 10:44:20 CET
I would also prefer that for things like Bug #42117, apps/the appcenter would put a script into a directory /etc/security/packetfilter.d/docker.d/ and that 20_docker.sh calls run-parts on it.
Comment 3 Ingo Steuwer univentionstaff 2020-07-03 20:51:04 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.