Bug 46267 - Enable php7 by default in UCS 4.3
Enable php7 by default in UCS 4.3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Arvid Requate
Erik Damrose
: interim-3
Depends on:
Blocks: 33214
  Show dependency treegraph
 
Reported: 2018-02-09 10:50 CET by Erik Damrose
Modified: 2018-03-14 14:38 CET (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Damrose univentionstaff 2018-02-09 10:50:13 CET
php7 is the default in stretch, and it should be enabled by default in UCS 4.3. In UCS 4.2 php5 is used, so when updating, we have to ensure we switch to php7.
Comment 1 Arvid Requate univentionstaff 2018-02-28 15:43:51 CET
Ok, I've adjusted univention-saml to depend on libapache2-mod-php7.0 and activate it in the postinst (replacing php5).

I've also taken this opportunity to remove references to php5:

c90113bb9f | management/univention-web - legacy dependency on php5-cli
22a1459f20 | test/ucs-test - Check permissions for /var/lib/php instead
b7342ef50d | Replace "php5-" in doc/app-tutorial and test/utils/base_appliance.sh
dddd9156c8 | changelog-4.3-0.xml
Comment 2 Arvid Requate univentionstaff 2018-02-28 16:01:30 CET
1a02b3ee11 | base/univention-updater - Deactivate php5 module in apache on update
Comment 3 Erik Damrose univentionstaff 2018-03-01 13:37:03 CET
OK: works on master / backup
But only because u-saml is installed there.

Fail: On other roles, the postup only deactivates the php5 apache2 module, but does not activate the php7.0 module. I think we should check if the module is available and activate it in the postup.
Please also redirect all output in the postup into the updater.log with >>"$UPDATER_LOG" 2>&1
I think the changelog should mention that the php5 module is deactivated and the php7.0 module is activated during the update
Comment 4 Arvid Requate univentionstaff 2018-03-01 21:58:39 CET
957fd812d9 | Deactivate php5 module already at the end of preup
af8f5752f9 | No need to do anything in univention-saml.postinst then
be42940b38 | Changelog

Packages are rebuilt.
Comment 5 Erik Damrose univentionstaff 2018-03-02 13:46:43 CET
OK: php5 gets disabled if it is enabled
OK: libapaache2-mod-php7.0 handles its own activation
OK: Update master, backup, slave with kopano, php correctly updated
OK: changelog
Verified
Comment 6 Stefan Gohmann univentionstaff 2018-03-14 14:38:50 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".