Bug 47386 – -- Default (unrestricted) -- differs from actually setting the rule unrestricted

Bug 47386 - -- Default (unrestricted) -- differs from actually setting the rule unrestricted


Summary:	-- Default (unrestricted) -- differs from actually setting the rule unrestricted

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	UMC - Internet rules
Version:	UCS@school 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.3 v5
Assigned To:	Jürn Brodersen
QA Contact:	Ole Schwiegert

URL:
Keywords:

Depends on:	44243
Blocks:
	Show dependency tree / graph

Reported:	2018-07-20 17:54 CEST by Jürn Brodersen
Modified:	2018-09-11 11:34 CEST (History)
CC List:	5 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.103
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Usability
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jürn Brodersen

2018-07-20 17:54:33 CEST

+++ This bug was initially created as a clone of Bug #44243 +++

Since bug 44243 the behaviour differs if the wlan settings differ depending on whether the frontend say "-- Default (unrestricted) --" (wlan not allowed) and if the rule is actually set (wlan allowed).
(ucs-school-ntlm-auth)

Also the default for new rules is still wlan=False.
(internetrules/__init__.py)

Comment 1 Jürn Brodersen

2018-08-29 14:57:44 CEST

Changed to "-- None (unrestricted/no WLAN) --". Since this would have been an api change anyways I moved the localization fully into the frontend.

[4.3 ec57d6f5c] Bug #47386: Changed description for unset rule
[4.3 5c38de89d] Bug #47386: move check.py into internetrules.py
[4.3 2a55b744d] Bug #47386: YAML

Comment 2 Ole Schwiegert

2018-08-30 09:16:21 CEST

Tested with ucs-test-ucsschool 5.0.2-85A~4.3.0.201808291453
ucs-school-umc-internetrules 14.0.0-2A~4.3.0.201808291312

Changelog & Advisory: OK
Test passes in local run: OK
New texts are present: OK

Comment 3 Sönke Schwardt-Krummrich

2018-09-11 11:34:18 CEST

UCS@school 4.3 v5 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.3v5-de.html

If this error occurs again, please clone this bug.