Description Jürn Brodersen 2019-02-22 14:19:31 CET

python-ucs-school postinst can destroy a system

It looks like "update-python-modules -f" crashed:
'''
Traceback (most recent call last):
File "/usr/sbin/update-python-modules", line 439, in <module>
shutil.rmtree(dir)
File "/usr/lib/python2.7/shutil.py", line 247, in rmtree
rmtree(fullname, ignore_errors, onerror)
File "/usr/lib/python2.7/shutil.py", line 256, in rmtree
onerror(os.rmdir, path, sys.exc_info())
File "/usr/lib/python2.7/shutil.py", line 254, in rmtree
os.rmdir(path)
OSError: [Errno 39] Directory not empty: '/usr/lib/pymodules/python2.7/univention'
'''
Which resulted in a mostly empty /usr/lib/pymodules/python2.7/univention directory and therefore all univention python modules stopped working.

The problematic file seems to have been:
univention/management/console/modules/schoolinstaller/__init__.py

I expect this call to be a workaround for https://hutten.knut.univention.de/blog/reproducible-build-zeitstempel-und-python-support/

update-python-modules was called after the debhelper section and should not be necessary outside of development, since update-python-modules is called through python_support in the debhelper section.

TLDR:
"update-python-modules --force-rebuild-all" should not be called without a very good reason.

An alternative would be "update-python-modules python-ucs-school.public" to only update the relevant files for python-ucs-school.