Univention Bugzilla – Bug 48823
Error message from libunivention-ldb-modules.postinst
Last modified: 2022-02-09 16:24:28 CET
Created attachment 9879 [details] fix_invoke-rc.d-policy-check.patch The attached patch should fix this error message coming from libunivention-ldb-modules.postinst: libunivention-ldb-modules (7.0.0-4A~4.4.0.201902172213) wird eingerichtet ... invoke-rc.d: syntax error: missing required parameter
This and a lot of other chnages are available in git:phahn/48823-ldb-modules [phahn/48823-ldb-modules] 038187cfe8 Bug #99999 ldb-modules: Fix compiler warning [phahn/48823-ldb-modules] 0637a2f923 Bug #99999 ldb-modules: Fix memory leaks [phahn/48823-ldb-modules] b3bd7c1aac Bug #99999 ldb-modules: Fix FD leak [phahn/48823-ldb-modules] 6cbdfc3ab1 Bug #99999 ldb-modules: Remove whitespace [phahn/48823-ldb-modules] 2c56c2a83d Bug #99999 ldb-modules: Fix pipe usage [phahn/48823-ldb-modules] 9e3e93f709 Bug #48823 ldb-modules: Fix postinst [phahn/48823-ldb-modules] b5062ce545 Bug #99999 ldb-modules: Python 3 [phahn/48823-ldb-modules] b74515963c Bug #99999 ldb-modules: Simplify build [phahn/48823-ldb-modules] e99fbeae34 Bug #99999 ldb-modules: build depends [phahn/48823-ldb-modules] df98194674 Bug #99999 ldb-modules: dbgsym [phahn/48823-ldb-modules] 3985bf2172 Bug #99999 ldb-modules: Remove WAF
The code is affected by - memory leaks - file descriptor leaks - missing error handling - hand rolled Debian packaging instead of using modern debhelper - Python 2 only code (1 line) All fixed by commits of comment #1
Rebased to 5.0-0: [phahn/48823-ldb-modules] f1cc50d0b8 style[ldb-modules] shellcheck issues [phahn/48823-ldb-modules] 243ea5a05c fix[ldb-modules] compiler warning strcmp() [phahn/48823-ldb-modules] 26a95d636b fix[ldb-modules] memory leaks [phahn/48823-ldb-modules] c016cfbf36 fix[ldb-modules] FD leak [phahn/48823-ldb-modules] 27202e08f9 style[ldb-modules] Remove white space [phahn/48823-ldb-modules] c1a4378a07 fix[ldb-modules] pipe usage [phahn/48823-ldb-modules] f291ce0f76 fix[ldb-modules] error by postinst query [phahn/48823-ldb-modules] 3d8d813374 refactor[ldb-modules] Simplify build rules [phahn/48823-ldb-modules] 307e46a52d refactor[ldb-modules] build depends [phahn/48823-ldb-modules] 397a852618 style[ldb-modules] Switch to dbgsym
(In reply to Philipp Hahn from comment #3) > [phahn/48823-ldb-modules] f291ce0f76 fix[ldb-modules] error by postinst query Watch out for Bug #44237 which claims UCS samba is not systemd compatible
[5.0-1] 316f599277 style[ldb-modules] shellcheck issues services/univention-ldb-modules/.gitignore | 1 + services/univention-ldb-modules/configure | 21 ++++++++------------- services/univention-ldb-modules/tests/test-soloading.sh | 33 +++++++++++++-------------------- 3 files changed, 22 insertions(+), 33 deletions(-) [5.0-1] aa4a0dd74d fix[ldb-modules] compiler warning strcmp() services/univention-ldb-modules/modules/univention_ldb_log.c | 1 + 1 file changed, 1 insertion(+) [5.0-1] 7c7bc58cc9 fix[ldb-modules] FD leak services/univention-ldb-modules/modules/univention_samaccountname_ldap_check.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) [5.0-1] 92442ecb51 fix[ldb-modules] memory leaks .../modules/univention_samaccountname_ldap_check.c | 46 ++++++++++++++--------------- 1 file changed, 22 insertions(+), 24 deletions(-) [5.0-1] a80ec1d22c style[ldb-modules] Remove white space .../debian/libunivention-ldb-modules.postinst | 2 -- services/univention-ldb-modules/modules/base64.c | 2 +- services/univention-ldb-modules/modules/univention_ldb_log.c | 32 ++++++++++++++--------------- .../modules/univention_samaccountname_ldap_check.c | 21 +++++++++---------- services/univention-ldb-modules/tests/test-soloading.sh | 1 - 5 files changed, 27 insertions(+), 31 deletions(-) [5.0-1] 9995d5bf6c fix[ldb-modules] pipe usage services/univention-ldb-modules/modules/univention_samaccountname_ldap_check.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) [5.0-1] bc4eb4e7f5 fix[ldb-modules] error by postinst query doc/errata/staging/univention-ldb-modules.yaml | 12 ++++++++++++ services/univention-ldb-modules/debian/changelog | 6 ++++++ services/univention-ldb-modules/debian/libunivention-ldb-modules.postinst | 4 +++- 3 files changed, 21 insertions(+), 1 deletion(-) [5.0-1] a340412545 refactor[ldb-modules] Simplify build rules services/univention-ldb-modules/.gitignore | 1 + services/univention-ldb-modules/Makefile | 53 ++++++----------------------- services/univention-ldb-modules/debian/clean | 2 ++ .../debian/libunivention-ldb-modules.install | 4 +-- services/univention-ldb-modules/debian/rules | 40 ++-------------------- 5 files changed, 16 insertions(+), 84 deletions(-) [5.0-1] 25dc221910 refactor[ldb-modules] build depends services/univention-ldb-modules/debian/control | 7 ------- services/univention-ldb-modules/wscript | 11 +---------- 2 files changed, 1 insertion(+), 17 deletions(-) [5.0-1] 0710ac643e style[ldb-modules] Switch to dbgsym services/univention-ldb-modules/debian/control | 17 ----------------- services/univention-ldb-modules/debian/rules | 3 --- 2 files changed, 20 deletions(-) Package: univention-ldb-modules Version: 8.0.0-6A~5.0.0.202202031157 Branch: ucs_5.0-0 Scope: errata5.0-1 [5.0-1] 0ad055fa0a Bug #48823: univention-ldb-modules 8.0.0-6A~5.0.0.202202031157 doc/errata/staging/univention-ldb-modules.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
OK: Error message from libunivention-ldb-modules.posinst gone OK: Code cleanup (Thanks for going over each patch with me, that was very helpful) OK: Code review OK: Joining a Windows Client to a ucs@school school server OK: SID allocation works OK: Tests OK: YAML Verified
<https://errata.software-univention.de/#/?erratum=5.0x204>