Bug 50816 – The use of "/" should be considered or restricted as letters for internet rule names

Bug 50816 - The use of "/" should be considered or restricted as letters for internet rule names


Summary:	The use of "/" should be considered or restricted as letters for internet rul...

Status:	NEW

Product:	UCS@school
Classification:	Unclassified
Component:	UMC - Internet rules
Version:	UCS@school 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	UCS@school maintainers
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-02-12 13:54 CET by Christina Scheinig
Modified:	2020-02-13 10:31 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.091
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2020021221000432
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Christina Scheinig

2020-02-12 13:54:35 CET

Teachers have defined internet rules that contain a "/".
noProxy/keinYoutube or 
cschein/keinYoutube

This looks like this in ucrV

proxy/filter/setting/cschein/keinYoutube/domain/blacklisted/1: www.youtube.com
proxy/filter/setting/cschein/keinYoutube/filtertype: blacklist-pass
proxy/filter/setting/cschein/keinYoutube/priority: 5
proxy/filter/setting/cschein/keinYoutube/wlan: false

The use of "/" should be caught here!

Comment 1 Erik Damrose

2020-02-12 14:39:42 CET

Which problem does occur when using / in an internet rule name?

Comment 2 Markus Dählmann 2020-02-13 09:58:22 CET

Aside from creating an invalid UCR structure, the new rule will not appear in the UMC at all after creation.
So maybe if a teacher has already filled the list of domains quite a bit, it will be frustrating for them to see that all work is lost after saving without knowing why.

Also, apparently there is already a check for invalid characters in place:
"Der Name muss eine Zeichenkette sein, die folgenden Sonderzeichen sind dabei nicht erlaubt: !, ", §, $, %, &, (, ), [, ], {, }, =, ?, `, +, #, ', ",", ;, <, >, \"
It is just missing the "/".