Univention Bugzilla – Bug 51003
treat empty ucrv as unset ucrv: ucsschool/import/generate/user/attributes/no-overwrite-by-schema
Last modified: 2020-06-10 14:35:59 CEST
When ucsschool/import/generate/user/attributes/no-overwrite-by-schema is an empty string, the import will not recognize it as unset and assume all attributes should be overwritten - including uid and mailPrimaryAddress. → ImportUser.no_overwrite_attributes will be [] instead of the default ["mailPrimaryAddress", "uid"]. 1. Handle the ucrv with an empty string in like if it were unset and use the default ("mailPrimaryAddress uid"). 2. Log the used value of the UCRV at the beginning, as it is part of the import configuration. Check for other UCRVs that are also relevant and log them too. This is essential for debugging import problems.
Added fix to branch troehmey/bug51003 with commit commit b511cbba1f3c04ce7e1f3cb806f325898bed7269 Bug #51003: fixed empty no-overwrite-attributes If no_overwrite_attributes is an empty list, it will be set to ["mailPrimaryAddress", "uid"]. Added logs for used ucr variables in ImportUser class. Waiting for QA
QA [troehmey/bug51003] b511cbba1 Bug #51003: fixed empty no-overwrite-attributes Code Review Why "mailPrimaryAddress uid".split() instead of ["mailPrimaryAddress", "uid"]? Use two whitespaces before comment. Functionality -> Works as expected. - Before the changes, when having the ucrv set to "", the field gets overwritten. After the change the values stay the same, same as if the ucrv would be unset. - ucrv mail/hosteddomains is logged when email is created with a schema.
Issue resolved with commit 72378e6df8b75c037fa6503b84948b41b3a9841f Bug #51003: minor fix on branch troehmey/bug51003. "mailPrimaryAddress uid".split() had no particular reason.
thanks for the adjustments! QA -> all ok -> please merge, add changelog and yaml and build. Code -> ok Functionality -> ok [troehmey/bug51003] 72378e6df Bug #51003: minor fix
Feature branch merged to 4.4 with commits commit 996a609a0b1afd138e6118c8ece1323fc1d97955 Bug #51003: added yaml commit 6c3bbac820bfb9e96a97b2569e9fd989015648d3 Bug #51003: added changelog entry commit 2d4f2a81321c2a9c2f732dd521f894ef027a29b4 Bug #51003: Merge branch 'troehmey/bug51003' into 4.4 commit 690e390aeaa9bd158d7c44d50e89669f315e4c51 Bug #51003: minor fix commit bd3468c831f32d42ac62a119cdc961bb4b5119de Bug #51003: fixed empty no-overwrite-attributes successful build: Package: ucs-school-import Version: 17.0.32A~4.4.0.202004271830 Branch: ucs_4.4-0 Scope: ucs-school-4.4
Changelog -> Ok Yaml -> Ok
UCS@school 4.4 v5 has been released (errata update to the release). https://docs.software-univention.de/changelog-ucsschool-4.4v5-de.html If this error occurs again, please clone this bug.