Bug 51472 - Update php-krb5 for UCS 5.0
Update php-krb5 for UCS 5.0
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: SAML
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Jürn Brodersen
Jannik Ahlers
:
: 52036 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-11 21:13 CEST by Jürn Brodersen
Modified: 2021-05-25 16:01 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Update php-krb5 packaging (11.08 KB, patch)
2020-06-12 10:26 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2020-06-11 21:13:14 CEST
Update php-krb5 from UCS 5.0

Update dependencies and upstream version for UCS 5.0
Comment 1 Jürn Brodersen univentionstaff 2020-06-12 09:02:49 CEST
[feature/ucs5 18fed73fac] Bug #51472: Update upstream version to 1.1.3
[feature/ucs5 944b939b85] Bug #51472: tar is now a build dependency

Commit "7510ec965df4087423aaf3c7e6c94183d47abc7f" is missing a bug number

Otherwise this is resolved
Comment 2 Philipp Hahn univentionstaff 2020-06-12 10:26:24 CEST
Created attachment 10386 [details]
Update php-krb5 packaging

I have some comments and corrections:

(In reply to Jürn Brodersen from comment #1)
> [feature/ucs5 944b939b85] Bug #51472: tar is now a build dependency

Please revert that as:
> $ dpkg -s tar
> Package: tar
> Essential: yes
Also xsltproc and po-debconf are not required for building.

debian/rules:
> CFLAGS = -O2 -Wall
> CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
You are overwriting the Debian defaults! COnsider switching to dh-php

debian/ucslint.overrides
Remove the last 3 lines as src/ is no longer part of the package and ucslint is no longer invoked by debian/rules

debian/control:
  Description is mangled

Overall the Debian packaging is very old and contains more issued. It should be switched to dh-php.

I took my time to create the attached patch series for you convenience.
Comment 3 Jürn Brodersen univentionstaff 2020-06-15 12:26:28 CEST
Patch looks good -> applied. Thanks!
[feature/ucs5 f15d4dac6b] Bug #51472 php-krb5: Remove ucslint.overrides
[feature/ucs5 35675a3200] Bug #51472 php-krb5: Add debian/watch
[feature/ucs5 4783fdb69c] Bug #51472 php-krb5: Remove useless build dependencies
[feature/ucs5 a549f608ab] Bug #51472 php-krb5: Switch to dh-php
Comment 4 Jürn Brodersen univentionstaff 2020-06-15 12:28:11 CEST
Or not. Build failed :(
Comment 5 Philipp Hahn univentionstaff 2020-06-15 13:29:29 CEST
(In reply to Jürn Brodersen from comment #4)
> Or not. Build failed :(

The php-krb5/Makefiles does not use `DESTDIR`, but `INSTALL_ROOT`:

From 279eee7d1db01ee55661ba9bcf0e194c0dc5ab17 Mon Sep 17 00:00:00 2001
Message-Id: <279eee7d1db01ee55661ba9bcf0e194c0dc5ab17.1592220574.git.hahn@univention.de>
From: Philipp Hahn <hahn@univention.de>
Date: Mon, 15 Jun 2020 13:29:13 +0200
Subject: [PATCH] fixup! Bug #51472 php-krb5: Switch to dh-php
Organization: Univention GmbH, Bremen, Germany

---
 saml/php-krb5/debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/saml/php-krb5/debian/rules b/saml/php-krb5/debian/rules
index a39afd8205..e3bb0db720 100755
--- a/saml/php-krb5/debian/rules
+++ b/saml/php-krb5/debian/rules
@@ -13,5 +13,8 @@ override_dh_auto_configure:
        cd src && phpize
        dh_auto_configure
 
+override_dh_auto_install:
+       dh_auto_install -- INSTALL_ROOT=$(CURDIR)/debian/php-krb5
+
 %:
        dh $@ --sourcedirectory=src --with php
-- 
2.20.1
Comment 6 Philipp Hahn univentionstaff 2020-06-15 13:47:52 CEST
[feature/ucs5] c6b22a4ed1 Bug #51472 php-krb5: Switch to dh-php
 saml/php-krb5/debian/rules | 3 +++
 1 file changed, 3 insertions(+)

Package: php-krb5
Version: 1.1.3-1A~5.0.0.202006151345
Branch: ucs_5.0-0

OK: dpkg -c /var/univention/buildsystem2//apt/ucs_5.0-0/amd64/php-krb5_1.1.3-1A~5.0.0.202006151345_amd64.deb
Comment 7 Jannik Ahlers univentionstaff 2020-06-15 16:14:24 CEST
- Installation works
- Upgrade works
- Removal works
-> Verified
Comment 8 Philipp Hahn univentionstaff 2021-03-03 08:42:07 CET
*** Bug 52036 has been marked as a duplicate of this bug. ***
Comment 9 Florian Best univentionstaff 2021-05-25 16:01:13 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".