Bug 52150 - install kelvin and its deps directly into container, don't use virtualenv
install kelvin and its deps directly into container, don't use virtualenv
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: HTTP-API (Kelvin)
UCS@school 4.4
Other Linux
: P5 normal (vote)
: ---
Assigned To: Daniel Tröder
Ole Schwiegert
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-09-29 12:08 CEST by Daniel Tröder
Modified: 2021-02-23 09:29 CET (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2020-09-29 12:08:32 CEST
The use of a Python virtualenv in the Kelvin Docker container is not required. There is no need to create a separate Python installation inside the Docker container, as there will never be another.
The use of a virtualenv however complicates the build and the usage (and slightly raises the image size). For example is it always necessary to active the virtualenv before using scripts and the ucr cli.

Install the Kelvin API and its dependencies directly into the Docker container.

Such a change has already been done for the ucsschool-id-connector, and there were no negative side effects, only positive.
Comment 1 Daniel Tröder univentionstaff 2021-02-01 17:50:53 CET
Fixed in:
[feature/kelvin 8291b5a1c] Bug #52150: build Docker image without virtualenv
Comment 2 Ole Schwiegert univentionstaff 2021-02-03 08:47:07 CET
Code Review: OK
Copyright updates: OK

REOPEN for build and new Kelvin App version for final tests.
Comment 3 Daniel Tröder univentionstaff 2021-02-11 11:03:08 CET
A new Docker image was build and the Kelvin app version 1.3.0 can now be installed form the test appcenter.
Comment 4 Tobias Wenzel univentionstaff 2021-02-11 13:43:01 CET
Final QA → All OK → VERIFY

- Kelvin app version 1.3.0 was uploaded to test appcenter.
- Changelog OK
- venv is no longer in Docker container
- tests run with `python3 -m pytest`
Comment 5 Daniel Tröder univentionstaff 2021-02-23 09:29:48 CET
A Kelvin API app with the changes in this bug has been published.