Bug 52251 - Migrate s4-connector tests to Python3
Migrate s4-connector tests to Python3
Status: CLOSED FIXED
Product: UCS Test
Classification: Unclassified
Component: S4 Connector
unspecified
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Florian Best
Arvid Requate
:
Depends on:
Blocks: 49898 51324
  Show dependency treegraph
 
Reported: 2020-10-24 00:38 CEST by Florian Best
Modified: 2021-05-27 10:43 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
bug52251-mapping-table.patch (1.20 KB, patch)
2021-01-24 19:44 CET, Arvid Requate
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2020-10-24 00:38:56 CEST
The S4-Connector tests needs to be migrated to Python 3.

Especially those who use python-samba, which is not available anymore in UCS 5.
Comment 1 Florian Best univentionstaff 2020-10-24 00:41:39 CEST
af7f2e02fadf | Bug #52251: migrate 133sync_sid to Python 3
3e97116bd1e1 | Bug #52251: migrate 100sync_gpo_ntsecurity_descriptor to Python 3
Comment 2 Florian Best univentionstaff 2020-11-03 12:37:15 CET
ucs-test (10.0.1-23)
2f7a7c7656a2 | fixup! Bug #52251: migrate S4-Connector tests to Python 3
8b550a781b87 | Bug #52251: migrate S4-Connector tests to Python 3
Comment 3 Arvid Requate univentionstaff 2021-01-24 19:44:13 CET
During the tests for AD-Takeover I discovered that the S4C doesn't consider the group mapping table,
because the entries are not encoded to bytes. It's the same issue I discovered in the AD-Connector.
Comment 4 Arvid Requate univentionstaff 2021-01-24 19:44:43 CET
Created attachment 10602 [details]
bug52251-mapping-table.patch
Comment 5 Florian Best univentionstaff 2021-02-01 21:16:34 CET
(In reply to Arvid Requate from comment #3)
> During the tests for AD-Takeover I discovered that the S4C doesn't consider
> the group mapping table,
> because the entries are not encoded to bytes. It's the same issue I
> discovered in the AD-Connector.

(In reply to Arvid Requate from comment #4)
> Created attachment 10602 [details]
> bug52251-mapping-table.patch

This is Bug #52043 and has been fixed in git:b88e5605196d87d50503e28643421d30ffad3977.
Comment 6 Arvid Requate univentionstaff 2021-03-23 16:20:10 CET
Tests are running.
Comment 7 Florian Best univentionstaff 2021-05-25 16:03:00 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".