Bug 52727 – [Kelvin API] use UDM REST API client with 'options' as a dict

Bug 52727 - [Kelvin API] use UDM REST API client with 'options' as a dict


Summary:	[Kelvin API] use UDM REST API client with 'options' as a dict

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	HTTP-API (Kelvin)
Version:	UCS@school 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Daniel Tröder
QA Contact:	Tobias Wenzel

URL:
Keywords:

Depends on:	50974
Blocks:	52659
	Show dependency tree / graph

Reported:	2021-02-01 09:07 CET by Daniel Tröder
Modified:	2021-02-23 09:30 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Feature Request
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2021-02-01 09:07:39 CET

Change the Kelvin API code to use the new UDM REST API client 0.5.0 with 'options' as a dict.

Comment 1 Daniel Tröder

2021-02-01 15:39:25 CET

The UCS@school lib and the Kelvin API code have been adapted to work with the API change of the UDM REST API client 0.5.0.
The tests have been fixed and improved.

In branch dtroeder/52727_options_dict:

[a5626ccd1] Bug #52727: use UDM REST API client 0.5.0 and adapt to API change ('options' as dict)
[d56c75ccd] Bug #52727: fix tests

Comment 2 Daniel Tröder

2021-02-11 09:37:21 CET

Version 1.0.1 is now required.

Comment 3 Daniel Tröder

2021-02-11 11:03:19 CET

Code has been merged into "feature/kelvin".
A new Docker image was build and the Kelvin app version 1.3.0 can now be installed form the test appcenter.

Comment 4 Tobias Wenzel

2021-02-11 15:10:16 CET

QA → Almost all OK → REOPEN

- new app version is present in test-app center (1.3.0)
- Code-changes → Looks good.
- udm-rest-client>=1.0.1 → in ucs-school-lib & kelvin-api
- tests → pass


in ucs-school-lib/modules/ucsschool/lib/tests/conftest.py

            grp_obj.props.ucsschoolRole = [
                create_ucsschool_role_string(role_school_class_share, sc_attrs["school"]),
            ]

looks like it should be
 
            share_obj.props.ucsschoolRole = [
                create_ucsschool_role_string(role_school_class_share, sc_attrs["school"]),
            ]

Comment 5 Daniel Tröder

2021-02-11 16:18:50 CET

Thanks, fixed it:
[feature/kelvin 96d814980] Bug #52727: fix typo

A new Docker image was build and uploaded.

Comment 6 Tobias Wenzel

2021-02-15 08:42:51 CET

QA: All OK → VERIFY

Comment 7 Daniel Tröder

2021-02-23 09:30:00 CET

A Kelvin API app with the changes in this bug has been published.