Univention Bugzilla – Bug 53355
Migrate univention-directory-notifier to Python 3
Last modified: 2023-08-18 09:09:24 CEST
univention-directory-notifier should be migrated to be Python 3 compatible. > management/univention-directory-notifier/univention-translog
Created attachment 10761 [details] Patch univention-translog for Python 3
In "management/univention-directory-notifier/debian/control" replace "python-univention-lib" with "python3-univention-lib".
13d0405998 | Make univention-translog prune idempotent 4b83c0e37b | Migrate univention-directory-notifier to Python 3 1bb9728302 | Advisory update dc5ecb65d0 | Advisory update
(In reply to Per Macha (ext) from comment #2) > In "management/univention-directory-notifier/debian/control" replace > "python-univention-lib" with "python3-univention-lib". Replaced - sorry I miss this one
This looks like a small regression: root@primary20:~# /usr/share/univention-directory-notifier/univention-translog Traceback (most recent call last): File "/usr/share/univention-directory-notifier/univention-translog", line 1444, in <module> exit(main()) File "/usr/share/univention-directory-notifier/univention-translog", line 424, in main return opt.func(opt) or 0 AttributeError: 'Namespace' object has no attribute 'func'
https://git.knut.univention.de/univention/ucs/-/merge_requests/192 Problem was due bit different way Python 3 handles argument parsing. It was not detected by 2to3 and also was not failing when some arguments were passed.
https://git.knut.univention.de/univention/ucs/-/merge_requests/192
4b83c0e37b | Migrate univention-directory-notifier to Python 3 1bb9728302 | Advisory update dc5ecb65d0 | Advisory update a35ba58c61 | update package dependency for python3 39818732c4 | Advisory update 858b07f42c | Advisory bddd2c7b91 | Migrate univention-directory-notifier to Python 3 8aba5f0f7b | Advisory update
OK: Code review OK: apt install ucs-test-directory-notifier/apt OK: ucs-test -E dangerous -s directory-notifier OK: univention-join FIXED: Python logging deprecation warning [5.0-0] 74a8c4894b Bug #53355: univention-directory-notifier 14.0.5-5A~5.0.0.202112061402 doc/errata/staging/univention-directory-notifier.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) [5.0-0] 7d49622914 style[univention-translog]: Fix deprecation doc/errata/staging/univention-directory-notifier.yaml | 2 +- management/univention-directory-notifier/debian/changelog | 6 ++++++ management/univention-directory-notifier/univention-translog | 4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) Package: univention-directory-notifier Version: 14.0.5-5A~5.0.0.202112061402 Branch: ucs_5.0-0 Scope: errata5.0-0 I extended ucs/test/ucs-test/tests/25_directory-notifier/01_univention_translog_tool.py and while doing this noticed Bug #54203 and Bug #54204. [5.0-0] e5fe3c0e68 test[univention-translog]: XFail bugs test/ucs-test/debian/changelog | 6 ++++++ test/ucs-test/debian/control | 1 + test/ucs-test/tests/25_directory-notifier/01_univention_translog_tool.py | 15 +++++++++++---- 3 files changed, 18 insertions(+), 4 deletions(-) [5.0-0] c8de0daefe doc[test]: PEP-484 type annotations test/ucs-test/univention/testing/conftest.py | 8 ++++++++ 1 file changed, 8 insertions(+) [5.0-0] 4dc3aa7587 style[test]: Use set comprehension test/ucs-test/univention/testing/conftest.py | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) Package: ucs-test Version: 10.0.6-81A~5.0.0.202112070832 Branch: ucs_5.0-0 Scope: errata5.0-0
<https://errata.software-univention.de/#/?erratum=5.0x169>