Univention Bugzilla – Bug 53366
Adjust ucs-school-umc-computerroom UMC module for UCS 5 Design
Last modified: 2021-11-29 17:19:38 CET
The package ucs-school-umc-computerroom needs to be adjusted for the new UCS 5.0 design.
Additionally an icon for the module has to be added.
e91adbcd1 Bug #53366: add icons 36afdc03e Bug #53366: escape message df2cabb2b Bug #53366: rename css class 2b9978388 Bug #53366: debian changelog 132ac3abc Bug #53366: adjust ucs-school-umc-computerroom for UCS 5 design
Created attachment 10776 [details] Screenshot REOPEN: There is not border/container around the screenshot view.
Created attachment 10777 [details] Screenshot REOPEN: The buttons are overlapping in presentation mode.
Created attachment 10778 [details] Screenshot When clicking on the context menu then, the Beobachten button gets moved.
Created attachment 10779 [details] Screenshot REOPEN: The screenshots used to be large - now the "large" screenshot is only 1/3 of the width.
Created attachment 10780 [details] Screenshot The default alternative image looks old school.
(In reply to Florian Best from comment #5) > Created attachment 10777 [details] > Screenshot > > REOPEN: The buttons are overlapping in presentation mode. Fixed (In reply to Florian Best from comment #6) > Created attachment 10778 [details] > Screenshot > > When clicking on the context menu then, the Beobachten button gets moved. Fixed (In reply to Florian Best from comment #7) > Created attachment 10779 [details] > Screenshot > > REOPEN: The screenshots used to be large - now the "large" screenshot is > only 1/3 of the width. Adjusted design (In reply to Florian Best from comment #4) > Created attachment 10776 [details] > Screenshot > > REOPEN: There is not border/container around the screenshot view. Adjusted design (In reply to Florian Best from comment #8) > Created attachment 10780 [details] > Screenshot > > The default alternative image looks old school. Adjusted design
https://git.knut.univention.de/univention/ucsschool/-/merge_requests/56
Created attachment 10802 [details] Info box does not have the same information as before When screenshots of a computer cannot be shown due to missing permissions of the current user (e.g. Administrator) there used to be an information text that can be seen on the previous screenshot. That info text is currently missing as seen on the latest screenshot.
Created attachment 10811 [details] old naming convention "slave" old naming convention ("slave") can still be found when creating a School
(In reply to Christian Castens from comment #12) > Created attachment 10811 [details] > old naming convention "slave" > > old naming convention ("slave") can still be found when creating a School This is not yet adjusted, will be done in Bug #52602.
All issues have been resolved, the module looks UCS 5-y again. As pointed out in Comment 11, the text about a logged in Administrator no longer appears, but instead the default "No screenshot can be shown, try again later" is shown. I did not find the place where they used the original message in 4.4. So I cannot say why this is not done anymore. But anyway, I think it is good enough as is.
REOPEN: The Selenium Test is failing: https://jenkins.knut.univention.de:8181/job/UCSschool-5.0/job/Install%20Singleserver/Config=s4,TestGroup=base1,UCSRelease=public/153/testReport/91_ucsschool-selenium/03_computerroom_endExam/master201/
Also during Upgrade: https://jenkins.knut.univention.de:8181/job/UCSschool-5.0/job/Upgrade%20Singleserver/lastCompletedBuild/Config=s4,TestGroup=base1/testReport/91_ucsschool-selenium/03_computerroom_endExam/master206/
fixed with 7349ec044daa87149b37eb400b0f3fa8774032d9
(In reply to Christian Castens from comment #11) > Created attachment 10802 [details] > Info box does not have the same information as before > > When screenshots of a computer cannot be shown due to missing permissions of > the current user (e.g. Administrator) there used to be an information text > that can be seen on the previous screenshot. That info text is currently > missing as seen on the latest screenshot. REOPEN: I am still seeing this issue. Maybe the SVG (or rendering of SVG) is broken?
305901593 Bug #53366: make svg cover while width 1afb8933e fixup! Bug #53366: ucs-school-umc-computerroom adjust screenshot view 7e869999d Bug #53665: set correct mimetype for screenshot and set initial screenshot
OK: SVG's are correctly shown and scaled.
UCS@school 5.0 v1 has been released. https://docs.software-univention.de/release-notes-ucsschool-5.0v1-de.html If this error occurs again, please clone this bug.