Univention Bugzilla – Bug 53768
51_samba4/63uid-to-sid_sid-to-uid_mapping failure not reported
Last modified: 2022-03-23 10:06:37 CET
Created attachment 10819 [details] ucs-test.log tests/51_samba4/63uid-to-sid_sid-to-uid_mapping failed, but ucs-test did not report it as a failing test. The test is using `fail_test`, but the "exit $RETVAL" at the end is missing. I have no idea why '/etc/ldap.secret' was missing. The traceback was later detected by 99_end/01_var_log_tracebacks.py <https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-0/job/AutotestJoin/563/> Relevant part from <https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-0/job/AutotestJoin/SambaVersion=s4,Systemrolle=slave/ws/test/ucs-test.log> attached below. PS: We should lint ucs-test for missing "exit $RETVAL" if "fail_test" is used.
[5.0-0] 63dcdea423 style[test]: shellcheck test/ucs-test/tests/49_nfs/10many-groups | 7 +++++-- test/ucs-test/tests/51_samba4/63uid-to-sid_sid-to-uid_mapping | 6 ++++-- 2 files changed, 9 insertions(+), 4 deletions(-) [5.0-0] 77b06aac33 fix[test]: Fail tests using fail_test test/ucs-test/debian/changelog | 6 ++++++ test/ucs-test/lint | 7 ++++++- test/ucs-test/tests/01_base/104_check-archive-keyring | 1 + test/ucs-test/tests/10_ldap/54listener-stdio | 3 ++- test/ucs-test/tests/49_nfs/10many-groups | 2 +- test/ucs-test/tests/51_samba4/63uid-to-sid_sid-to-uid_mapping | 2 ++ test/ucs-test/tests/80_docker/11_registry_access | 1 + 7 files changed, 19 insertions(+), 3 deletions(-) Package: ucs-test Version: 10.0.6-41A~5.0.0.202109101410 Branch: ucs_5.0-0 Scope: errata5.0-0 ? backport to 4.4-8 ?
Great! I love my traceback-grep tool. /etc/ldap.secret was missing on multiple systems. We should open a new bug for this if it happens again tomorrow. I executed the `lint` tool also against the UCS@school tests but found only a minor issue and many false-positives.
Follow-up Bug #53777
0dd66cfb2e..fbfad71eef Package: ucs-test Version: 10.0.6-45A~5.0.0.202109142117 Branch: ucs_5.0-0 Scope: errata5.0-0
Code-Review: OK
not sure whats going on here, but i think this 42f5265fc7acd9b607721b4c733f20204bb32ffd breaks the tests [master090] 2021-09-18T00:48:13.296646 tus ........................................ [master090] 2021-09-18T00:48:13.299731 Traceback (most recent call last): [master090] 2021-09-18T00:48:13.299731 File "/usr/sbin/ucs-test", line 210, in <module> [master090] 2021-09-18T00:48:13.299731 sys.exit(main()) [master090] 2021-09-18T00:48:13.299731 File "/usr/sbin/ucs-test", line 203, in main [master090] 2021-09-18T00:48:13.299731 return test_set.run_tests(options.filter, options.dry, options.hold) [master090] 2021-09-18T00:48:13.299731 File "/usr/sbin/ucs-test", line 130, in run_tests [master090] 2021-09-18T00:48:13.299731 test_case = TestCase(fname).load() [master090] 2021-09-18T00:48:13.299731 File "/usr/lib/python3/dist-packages/univention/testing/data.py", line 536, in load [master090] 2021-09-18T00:48:13.299731 with open(self.filename, 'rb') as tc_file: [master090] 2021-09-18T00:48:13.299731 FileNotFoundError: [Errno 2] No such file or directory: '/usr/share/ucs-test/21_appcenter-uninstall/10_user_creation'
(In reply to Felix Botner from comment #6) > not sure whats going on here, but i think this > 42f5265fc7acd9b607721b4c733f20204bb32ffd breaks the tests > > > [master090] 2021-09-18T00:48:13.296646 tus > ........................................ > [master090] 2021-09-18T00:48:13.299731 Traceback (most recent call last): > [master090] 2021-09-18T00:48:13.299731 File "/usr/sbin/ucs-test", line > 210, in <module> > [master090] 2021-09-18T00:48:13.299731 sys.exit(main()) > [master090] 2021-09-18T00:48:13.299731 File "/usr/sbin/ucs-test", line > 203, in main > [master090] 2021-09-18T00:48:13.299731 return > test_set.run_tests(options.filter, options.dry, options.hold) > [master090] 2021-09-18T00:48:13.299731 File "/usr/sbin/ucs-test", line > 130, in run_tests > [master090] 2021-09-18T00:48:13.299731 test_case = TestCase(fname).load() > [master090] 2021-09-18T00:48:13.299731 File > "/usr/lib/python3/dist-packages/univention/testing/data.py", line 536, in > load > [master090] 2021-09-18T00:48:13.299731 with open(self.filename, 'rb') as > tc_file: > [master090] 2021-09-18T00:48:13.299731 FileNotFoundError: [Errno 2] No such > file or directory: > '/usr/share/ucs-test/21_appcenter-uninstall/10_user_creation' Actually the change did the right thing and showed as there were some broken links in ucs-test-appcenter-uninstall, fixed those links. Time to rework that ucs-test-appcenter-uninstall thing.
OK