Bug 54664 - [4.4] univention-network-manager should use the official UMC API
[4.4] univention-network-manager should use the official UMC API
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Network
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-9-errata
Assigned To: Johannes Lohmer
Florian Best
https://git.knut.univention.de/univen...
:
Depends on: 42128 52959
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-12 12:55 CEST by Florian Best
Modified: 2022-07-28 09:11 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2022-04-12 12:55:34 CEST
We should backport Bug #42128 and (partly?!) Bug #52959 to UCS 4.4.
This removes the dependency on UMCP in UCS 4.4 so that we can still support mixed environments with UCS 5.x without an UMC-Server.


+++ This bug was initially created as a clone of Bug #42128 +++

It would be better to use the HTTP API of UMC instead of the command line tool "umc-command" which goes directly against the UMC-Server.
Attached is a patch which modifies univention-register-network-address to use the univention-lib function.
Comment 2 Johannes Lohmer univentionstaff 2022-07-21 10:50:11 CEST
univention-network-manager (11.0.0-3)
033ee0fd83b1 | Bug #54664: Let univention-register-network-address do the retries
e38ff97084e9 | Bug #54664: make univention-network-common unit wait for UMC-web-server
d046779c5319 | Bug #54664: use univention.lib.umc instead of umc-command


How to Test:

Two servers, one with a dhcp server, one getting a dynamic ip from the first server.

1. Test:

Change the IP information of the dhcp client udm computer object on the UCS primary/master server.

On the computer with dynamic dhcp ip address:
Run the script manually: `/usr/sbin/univention-register-network-address --verbose --force` or
restart the .init service: `service univention-network-common restart`
or reboot the machine.

2. Test:

Change the IP address of the client dhcp object in the LDAP of the primary/master server. (Not the computers/computer object but the dhcp/<dhcp_server_name> object>

reboot the computer with dynamic dhcp ip address.
It should now have the ip, specified above and the udm computer object should have changed aswell.
Comment 3 Florian Best univentionstaff 2022-07-25 13:30:26 CEST
OK: test via DC Slave
OK: test via DC Master
OK: code review 
OK: YAML