Bug 54897 - Switch {/var/ → /}run and {/var → /run}/lock
Switch {/var/ → /}run and {/var → /run}/lock
Status: NEW
Product: UCS
Classification: Unclassified
Component: General
UCS 5.0
Other Linux
: P5 normal (vote)
: ---
Assigned To: UCS maintainers
UCS maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2022-06-24 13:42 CEST by Philipp Hahn
Modified: 2022-06-24 13:51 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize, Cleanup, Debt Technical
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2022-06-24 13:42:05 CEST
/var/run/ is already a symbolic link to /run/, which is as an ephemeral tmpfs; see <https://wiki.debian.org/ReleaseGoals/RunDirectory#Why_can.27t_.2Fvar.2Frun_and_.2Fvar.2Flock_stay_under_.2Fvar.3F> and <https://www.freedesktop.org/software/systemd/man/tmpfiles.d.html#/run/%20and%20/var/run/>

`dmesg -H` is full of warnings:
> systemd[1]: /run/systemd/generator.late/univention-s4-connector.service:22: PIDFile= references path below legacy directory /var/run/, updating /var/run/univention-s4-connector → /run/univention-s4-connector; please update the unit file accordingly.
> systemd[1]: /run/systemd/generator.late/univention-ad-connector.service:21: PIDFile= references path below legacy directory /var/run/, updating /var/run/univention-ad-connector → /run/univention-ad-connector; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/spamassassin.service:6: PIDFile= references path below legacy directory /var/run/, updating /var/run/spamd.pid → /run/spamd.pid; please update the unit file accordingly.
> systemd[1]: /run/systemd/generator.late/slapd.service:20: PIDFile= references path below legacy directory /var/run/, updating /var/run/slapd/slapd.pid → /run/slapd/slapd.pid; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/rpc-statd.service:13: PIDFile= references path below legacy directory /var/run/, updating /var/run/rpc.statd.pid → /run/rpc.statd.pid; please update the unit file accordingly.
> systemd[1]: /lib/systemd/system/nagios-nrpe-server.service:12: PIDFile= references path below legacy directory /var/run/, updating /var/run/nagios/nrpe.pid → /run/nagios/nrpe.pid; please update the unit file accordingly.

# git grep -l /var/run/ -- ':!**/debian/changelog' | cat
base/univention-base-files/conffiles/etc/ssh/sshd_config
base/univention-config-registry/python/univention/service_info.py
base/univention-heimdal/conffiles/etc/init.d/heimdal-kdc
base/univention-lib/python/locking.py
base/univention-lib/unittests/test_locking.py
base/univention-network-manager/etc/network/if-down.d/15_nscd
base/univention-network-manager/etc/network/if-up.d/05_rdate
base/univention-network-manager/etc/network/if-up.d/15_nscd
base/univention-pam/debian/univention-pam.postinst
base/univention-system-setup/umc/python/setup/netconf/conditions.py
base/univention-system-setup/usr/lib/univention-system-setup/cleanup-post.d/06_remove_no_ldap_status_file
base/univention-system-setup/usr/lib/univention-system-setup/scripts/setup-join.sh
base/univention-updater/modules/univention/updater/locking.py
base/univention-updater/script/postup.sh
container/univention-docker/conffiles/etc/default/docker
doc/developer-reference/join/join.xml
doc/developer-reference/ucr/service/conffiles/etc/init.d/atd
mail/univention-antivir-mail/conffiles/etc/amavis/conf.d/60-univention
mail/univention-antivir-mail/conffiles/etc/clamav/clamd.conf
mail/univention-antivir-mail/conffiles/etc/clamav/freshclam.conf
mail/univention-antivir-mail/debian/univention-antivir-mail.postinst
mail/univention-mail-dovecot/conffiles/etc/dovecot/conf.d/10-mail.conf
mail/univention-mail-dovecot/conffiles/etc/dovecot/dovecot.conf
mail/univention-mail-dovecot/conffiles/etc/init.d/dovecot
mail/univention-mail-postfix/conffiles/etc/postfix/sasl/smtpd.conf
mail/univention-postgrey/conffiles/etc/init.d/postgrey
mail/univention-spamassassin/conffiles/etc/default/spamassassin
management/univention-appcenter/python/appcenter/packages.py
management/univention-directory-listener/debian/tests/filter
management/univention-directory-manager-rest/src/univention/admin/rest/server/__init__.py
management/univention-directory-notifier/import_translog.sh
management/univention-directory-notifier/src/univention-directory-notifier.c
management/univention-join/joinscripthelper.lib
management/univention-join/univention-run-join-scripts
management/univention-ldap/conffiles/etc/init.d/slapd
management/univention-ldap/conffiles/etc/ldap/slapd.conf.d/30univention-ldap-server_head
management/univention-ldap/conffiles/etc/ldap/slapd.conf.d/39configdb
management/univention-ldap/conffiles/etc/ldap/slapd.conf.d/60univention-ldap-server_acl-master
management/univention-ldap/conffiles/etc/ldap/slapd.conf.d/60univention-ldap-server_acl-slave
management/univention-ldap/conffiles/etc/ldap/slapd.conf.d/99translog
management/univention-management-console-module-diagnostic/umc/python/diagnostic/plugins/31_file_permissions.py
management/univention-management-console/debian/univention-management-console-server.init
management/univention-management-console/debian/univention-management-console-web-server.init
management/univention-management-console/scripts/postrotate
management/univention-management-console/scripts/univention-management-console-module
management/univention-management-console/scripts/univention-management-console-server
management/univention-management-console/src/univention/management/console/protocol/session.py
management/univention-management-console/systemd/system/univention-management-console-web-server@.service
management/univention-management-console/univention-management-console-web-server
monitoring/univention-monitoring-client/alerts/check_univention_nscd
monitoring/univention-nagios/conffiles/etc/init.d/nagios-nrpe-server
monitoring/univention-nagios/conffiles/etc/nagios/nagios.cfg
monitoring/univention-nagios/conffiles/etc/nagios/nrpe.cfg
monitoring/univention-nagios/usr/lib/nagios/plugins/check_univention_nscd
saml/univention-saml/conffiles/etc/memcached_univention_saml.conf
saml/univention-saml/conffiles/etc/simplesamlphp/config.php
saml/univention-saml/conffiles/etc/stunnel/univention_saml.conf
services/univention-ad-connector/debian/univention-ad-connector.init
services/univention-ad-connector/modules/univention/connector/ad/main.py
services/univention-dhcp/univention-dhcp.conf
services/univention-net-installer/debian/univention-net-installer-daemon.init.d
services/univention-net-installer/univention-net-installer-daemon
services/univention-postgresql/conffiles/etc/postgresql/11/main/postgresql.conf
services/univention-printserver/conffiles/etc/cups/cups-files.conf
services/univention-radius/conffiles/etc/freeradius/3.0/radiusd.conf
services/univention-s4-connector/debian/univention-s4-connector.init
services/univention-s4-connector/modules/univention/s4connector/s4/main.py
services/univention-samba/conffiles/etc/logrotate.d/samba
services/univention-samba/conffiles/etc/logrotate.d/winbind
services/univention-samba4/lib/base.sh
services/univention-sasl/conffiles/etc/default/saslauthd
test/ucs-test/tests/01_base/25check-permissions
test/ucs-test/tests/10_ldap/24uldap
test/ucs-test/tests/10_ldap/56ppolicy_account_lockout_concurrent
test/ucs-test/tests/99_end/grep_traceback.py
Comment 1 Philipp Hahn univentionstaff 2022-06-24 13:50:43 CEST
Similar for /var/lock/ → /run/lock/:

# git grep -l /var/lock/ -- ':!**/debian/changelog' ':!packaging/ucslint/testframework/'
base/univention-updater/debian/univention-updater.univention-maintenance.init
base/univention-updater/modules/univention/updater/locking.py
management/univention-join/umc/python/join/__init__.py
services/univention-ad-connector/modules/univention/connector/ad/main.py
services/univention-s4-connector/modules/univention/s4connector/s4/main.py
services/univention-samba4/debian/univention-samba4-sysvol-sync.postinst
services/univention-samba4/sysvol-sync-scripts/sysvol-sync.sh
test/ucs-test/tests/09_updater/pool.sh
test/univention-demo-configuration/debian/univention-demo-configuration.init
test/utils/utils.sh