Bug 54988 – Traceback in 40_samba_tool_dbcheck.py (63_proof_uniqueMembers.py ?) when running the fix function

Bug 54988 - Traceback in 40_samba_tool_dbcheck.py (63_proof_uniqueMembers.py ?) when running the fix function


Summary:	Traceback in 40_samba_tool_dbcheck.py (63_proof_uniqueMembers.py ?) when runn...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - System diagnostic
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-2-errata
Assigned To:	Maximilian Janßen
QA Contact:	Florian Best

URL:	https://git.knut.univention.de/univen...
Keywords:

Duplicates:	54856 55043 (view as bug list)
Depends on:	48652
Blocks:	54929 54856
	Show dependency tree / graph

Reported:	2022-07-14 13:10 CEST by Jürn Brodersen
Modified:	2022-07-31 14:46 CEST (History)
CC List:	4 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.137
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	bitesize, Regression
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jürn Brodersen

2022-07-14 13:10:36 CEST

+++ This bug was initially created as a clone of Bug #48652 +++

Traceback in 40_samba_tool_dbcheck.py (63_proof_uniqueMembers.py ?) when running the fix function.

Trying to use the automatic fix for 40_samba_tool_dbcheck results in a traceback. Looking at the code I think 63_proof_uniqueMembers has the same problem but I didn't test it.

Problem:
The decode is now already done within the "run_with_output" function.

Traceback:
'''
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/diagnostic/__init__.py", line 280, in execute
    result = execute(umc_module, **kwargs)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/diagnostic/plugins/40_samba_tool_dbcheck.py", line 55, in run_samba_tool_dbcheck_fix
    fix_log.append(output.decode('utf-8', 'replace'))
AttributeError: 'str' object has no attribute 'decode'
'''

Comment 1 Maximilian Janßen

2022-07-26 15:09:56 CEST

univention-management-console-module-diagnostic.yaml
0213b74e8a7f | Bug #54988: Diagnostic module crash due to duplicate decode

univention-management-console-module-diagnostic (6.0.2-2)
0213b74e8a7f | Bug #54988: Diagnostic module crash due to duplicate decode

Comment 2 Florian Best

2022-07-27 08:17:09 CEST

*** Bug 54856 has been marked as a duplicate of this bug. ***

Comment 3 Florian Best

2022-07-27 08:24:39 CEST

OK: fix button works again
OK: YAML

Comment 4 Philipp Hahn

2022-07-28 09:11:30 CEST

<https://errata.software-univention.de/#/?erratum=5.0x372>

Comment 5 Florian Best

2022-07-31 14:46:09 CEST

*** Bug 55043 has been marked as a duplicate of this bug. ***