Univention Bugzilla – Bug 56363
91univention-saml.inst assumes it failed if it was already executed
Last modified: 2023-08-28 14:12:52 CEST
Created attachment 11100 [details] error message The join script checks the last return code to see if it failed. This way it assumes it failed because "joinscript_init" returns 1 and exits the joinscript if it was already executed. The message doesn't break anything, but is confusing. I noticed it during a package upgrade. How to reproduce: apt install --reinstall univention-saml I think moving the trap registration part under the "joinscript_init" command, should help. https://git.knut.univention.de/univention/ucs/-/tree/5.0-4/saml/univention-saml#L95 By the way, that whole debug print is an interesting idea :)
(In reply to Jürn Brodersen from comment #0) > Created attachment 11100 [details] > error message > > The join script checks the last return code to see if it failed. This way it > assumes it failed because "joinscript_init" returns 1 and exits the > joinscript if it was already executed. The message doesn't break anything, > but is confusing. I noticed it during a package upgrade. > > How to reproduce: > apt install --reinstall univention-saml > > I think moving the trap registration part under the "joinscript_init" > command, should help. > https://git.knut.univention.de/univention/ucs/-/tree/5.0-4/saml/univention- > saml#L95 > > By the way, that whole debug print is an interesting idea :) I could find other words for that. I thing this must be configurable, otherwise we need to modify the joinscript, getting rid of this messages everytime to find the error. This is worse than spam, for a non developer. ( no offense ) I searched for the Bug where this was introduced, but did not find it.