Attachment 8252 Details for Bug 40492 – proposed patch

[patch] proposed patch

40492.patch (text/plain), 3.93 KB, created by Jürn Brodersen on 2016-11-29 12:56:32 CET

(hide)

Description:

Filename:

MIME Type:

Creator: Jürn Brodersen

Created: 2016-11-29 12:56:32 CET

Size: 3.93 KB

patch

obsolete

>Index: univention-management-console-frontend/debian/changelog
>===================================================================
>--- univention-management-console-frontend/debian/changelog	(Revision 74791)
>+++ univention-management-console-frontend/debian/changelog	(Arbeitskopie)
>@@ -1,3 +1,9 @@
>+univention-management-console-frontend (5.0.63-53) unstable; urgency=medium
>+
>+  * Bug #40492: Hide overflow on session timeout 
>+
>+ -- JÃ¼rn Brodersen <brodersen@univention.de>  Tue, 29 Nov 2016 12:53:00 +0100
>+
> univention-management-console-frontend (5.0.63-52) unstable; urgency=medium
> 
>   * Bug #42979: Added english banner for the Univention Summit message
>Index: univention-management-console-frontend/umc/dialog/LoginDialog.js
>===================================================================
>--- univention-management-console-frontend/umc/dialog/LoginDialog.js	(Revision 74791)
>+++ univention-management-console-frontend/umc/dialog/LoginDialog.js	(Arbeitskopie)
>@@ -26,7 +26,7 @@
>  * /usr/share/common-licenses/AGPL-3; if not, see
>  * <http://www.gnu.org/licenses/>.
>  */
>-/*global define console window setTimeout require*/
>+/*global define, console, window, setTimeout, require*/
> 
> define([
> 	"dojo/_base/declare",
>@@ -222,7 +222,7 @@
> 						}));
> 						return;
> 					}
>-					if (name == 'umcLoginForm') {
>+					if (name === 'umcLoginForm') {
> 						this._submitFakeForm();
> 					}
> 					// FIXME: if custom prompts and(!) new password is required we should just switch the view
>@@ -252,7 +252,7 @@
> 			});
> 
> 			// validate new password form
>-			if (name == 'umcNewPasswordForm' && newPasswordInput.value && newPasswordInput.value !== newPasswordRetypeInput.value) {
>+			if (name === 'umcNewPasswordForm' && newPasswordInput.value && newPasswordInput.value !== newPasswordRetypeInput.value) {
> 				this.set('LoginMessage', '<h1>' + _('Changing password failed') + '</h1><p>' +  _('The passwords do not match, please retype again.') + '</p>');
> 				return;
> 			}
>@@ -466,6 +466,11 @@
> 		_show: function() {
> 			var deferred;
> 			query('#umcLoginWrapper').style('display', 'block');
>+			query('body').style('overflow', 'hidden');
>+			if (has('safari')) {
>+				this._safariScrollPosY = window.scrollY;
>+				query('body').style('position', 'fixed');
>+			}
> 			query('#umcLoginDialog').style('opacity', '1');  // baseFx.fadeOut sets opacity to 0
> 			this._setFocus();
> 			if (has('ie') < 10) {
>@@ -518,6 +523,11 @@
> 			// hide the dialog
> 			var hide = lang.hitch(this, function() {
> 				query('#umcLoginWrapper').style('display', 'none');
>+				query('body').style('overflow', '');
>+				if (has('safari')) {
>+					query('body').style('position', '');
>+					window.scrollTo(0, this._safariScrollPosY);
>+				}
> 				Dialog._DialogLevelManager.hide(this);
> 				this.standby(false);
> 				try {
>Index: univention-management-console-frontend-theme/debian/changelog
>===================================================================
>--- univention-management-console-frontend-theme/debian/changelog	(Revision 74564)
>+++ univention-management-console-frontend-theme/debian/changelog	(Arbeitskopie)
>@@ -1,3 +1,9 @@
>+univention-management-console-frontend-theme (1.0.4-6) unstable; urgency=medium
>+
>+  * Bug #40492: Show session timeout dialog centered to the viewport 
>+
>+ -- JÃ¼rn Brodersen <brodersen@univention.de>  Fri, 18 Nov 2016 10:53:45 +0100
>+
> univention-management-console-frontend-theme (1.0.4-5) unstable; urgency=medium
> 
>   Bug #38622:
>Index: univention-management-console-frontend-theme/dijit-claro-stylus/site/login.styl
>===================================================================
>--- univention-management-console-frontend-theme/dijit-claro-stylus/site/login.styl	(Revision 74564)
>+++ univention-management-console-frontend-theme/dijit-claro-stylus/site/login.styl	(Arbeitskopie)
>@@ -1,10 +1,11 @@
> @import "../variables";
> 
> #umcLoginWrapper {
>-	position: absolute;
>+	position: fixed;
> 	height: 100%;
> 	width: 100%;
> 	display: none;
>+	overflow: auto;
> }
> 
> #umcLoginDialog, .umcLoginDialog {

Actions: View | Diff

Attachments on bug 40492: 7428 | 8250 | 8252