Bug 40492 – Login dialog after session time out is shown on the top of the page

Bug 40492 - Login dialog after session time out is shown on the top of the page


Summary:	Login dialog after session time out is shown on the top of the page

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.1-4-errata
Assigned To:	Jürn Brodersen
QA Contact:	Alexander Kläser

URL:
Keywords:

Depends on:
Blocks:	43091
	Show dependency tree / graph

Reported:	2016-01-25 12:44 CET by Alexander Kläser
Modified:	2016-12-02 14:03 CET (History)
CC List:	1 user (show)

See Also:	43105
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	4: Will affect most installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.183
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Design, Mobile devices/tablets, Usability
Max CVSS v3 score:

Attachments
Screenshot with login screen in the upper part of the display (25.79 KB, image/png) 2016-01-25 12:44 CET, Alexander Kläser	Details
proposed patch (3.69 KB, patch) 2016-11-29 10:47 CET, Jürn Brodersen	Details \| Diff
proposed patch (3.93 KB, patch) 2016-11-29 12:56 CET, Jürn Brodersen	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2016-01-25 12:44:22 CET

Created attachment 7428 [details]
Screenshot with login screen in the upper part of the display

... cf. screenshot attached. This may be especially tricky on mobile devices when one has scrolled down: Then the background is only greyed out. It would be helpful (in very easy) to scroll the login dialogue in view.

Comment 1 Jürn Brodersen

2016-11-29 10:47:08 CET

Created attachment 8250 [details]
proposed patch

This patch sets the login dialog fix to the middle of the screen and disables scrolling for the page underneath.

Comment 2 Jürn Brodersen

2016-11-29 12:56:32 CET

Created attachment 8252 [details]
proposed patch

Added safari workaround

Comment 3 Jürn Brodersen

2016-11-29 16:45:13 CET

r74796: Hide overflow on session timeout
Package: univention-management-console-frontend
Version: 5.0.63-53.1247.201611291635
Branch: ucs_4.1-0
Scope: errata4.1-4

r74798: Show session timeout dialog centered on the viewport
Package: univention-management-console-frontend-theme
Version: 1.0.4-8.118.201611291639
Branch: ucs_4.1-0
Scope: errata4.1-4

r74803: YAML

Comment 4 Alexander Kläser

2016-12-01 12:01:13 CET

In FF (mobile view), I could provoke scrolling to the top after relogin. As discussed, please adjust the code to scroll to the top when the login dialog is shown and to scroll back after relogin.

Comment 5 Jürn Brodersen

2016-12-01 12:53:19 CET

For the time being we just scroll to the top of the page and scroll back to the old position after relogin.

r74886: Scroll to the top of the page on a session timeout
Package: univention-management-console-frontend
Version: 5.0.63-56.1250.201612011249
Branch: ucs_4.1-0
Scope: errata4.1-4

Comment 6 Alexander Kläser

2016-12-01 14:42:12 CET

As discussed, please revert the changes in the umc-frontend-theme package :) .

Comment 7 Jürn Brodersen

2016-12-01 14:50:03 CET

r74899: revert display fixed because IOs doesn't like it
Package: univention-management-console-frontend-theme
Version: 1.0.4-11.121.201612011446
Branch: ucs_4.1-0
Scope: errata4.1-4

Comment 8 Alexander Kläser

2016-12-01 15:55:16 CET

Testing results:
  Edge 12/13: OK
  IE 11: does not scroll back after login
  Safari 10: OK
  iPad 4: OK

Changes: OK, overall this is an improvement to the current situation
YAML file: OK, removed entry from umc-frontend-theme package [r74907]
Merge to 4.2-0: Latest changes have not been merged → created Bug 43091 for that

→ VERIFIED

Comment 9 Alexander Kläser

2016-12-01 15:57:02 CET

(In reply to Alexander Kläser from comment #8)
> Testing results:
>   Edge 12/13: OK
>   IE 11: does not scroll back after login
>   Safari 10: OK
>   iPad 4: OK

FF: OK

Comment 10 Janek Walkenhorst

2016-12-01 16:27:11 CET

<http://errata.software-univention.de/ucs/4.1/349.html>

Comment 11 Jürn Brodersen

2016-12-01 16:27:45 CET

IE needs window.pageYOffset instead of window.scrollY...
Sorry, I will open a new bug for that.