Attachment 9520 Details for Bug 43037

[patch] Patch proposal for exam only label

43037_proposal1.patch (text/plain), 1.75 KB, created by Ole Schwiegert on 2018-04-30 11:15 CEST

(hide)

Description:

Filename:

MIME Type:

Creator: Ole Schwiegert

Created: 2018-04-30 11:15 CEST

Size: 1.75 KB

patch

obsolete

>diff --git a/ucs-school-umc-computerroom/umc/js/computerroom/SettingsDialog.js b/ucs-school-umc-computerroom/umc/js/computerroom/SettingsDialog.js
>index 59273cbc..e05423ed 100644
>--- a/ucs-school-umc-computerroom/umc/js/computerroom/SettingsDialog.js
>+++ b/ucs-school-umc-computerroom/umc/js/computerroom/SettingsDialog.js
>@@ -94,7 +94,7 @@ define([
> 				label: _('Share access'),
> 				description: _('Defines restriction for the share access'),
> 				staticValues: [
>-					{ id: 'home', label: _('Home directory only') },
>+					{ id: 'home', label: this.exam ? _('Exam files only') : _('Home directory only') },
> 					{ id: 'all', label: _('Default (no restrictions)') }
> 				]
> 			}, {
>@@ -163,6 +163,11 @@ define([
> 		},
> 
> 		update: function() {
>+			// resetting the static values of the shareMode ComboBox to display label changes due to this.exam
>+			this._form.getWidget("shareMode").set("staticValues", [
>+				{ id: 'home', label: this.exam ? _('Exam files only') : _('Home directory only') },
>+				{ id: 'all', label: _('Default (no restrictions)') }
>+			]);
> 			// load settings and update form
> 			return this.umcpCommand('computerroom/settings/get').then(lang.hitch(this, function(response) {
> 				tools.forIn(response.result, function(key, value) {
>diff --git a/ucs-school-umc-exam/umc/js/schoolexam.js b/ucs-school-umc-exam/umc/js/schoolexam.js
>index 764df596..235367d6 100644
>--- a/ucs-school-umc-exam/umc/js/schoolexam.js
>+++ b/ucs-school-umc-exam/umc/js/schoolexam.js
>@@ -280,7 +280,7 @@ define([
> 					description: _( 'Defines restriction for the share access' ),
> 					staticValues: [{
> 						id: 'home',
>-						label : _('Restrict access to home directory')
>+						label : _('Exam files only')
> 					}, {
> 						id: 'all',
> 						label : _('Allow access to all shares')

Actions: View | Diff

Attachments on bug 43037: 9520