Bug 30798
| Summary: | No progress during app center dry_run | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Stefan Gohmann <gohmann> |
| Component: | UMC - App-Center | Assignee: | Dirk Wiesenthal <wiesenthal> |
| Status: | CLOSED FIXED | QA Contact: | Felix Botner <botner> |
| Severity: | enhancement | ||
| Priority: | P5 | CC: | jmm, klaeser |
| Version: | UCS 3.1 | ||
| Target Milestone: | UCS 3.1-1-errata | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| What kind of report is it?: | --- | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | Release Goal | |
| Max CVSS v3 score: | |||
| Bug Depends on: | 30984 | ||
| Bug Blocks: | |||
|
Description
Stefan Gohmann
Put the whole appcenter/invoke in a giant thread. Now it is possible to poll progress not only during installation but also during dry_run just before that. Used Bug#30984 because now the ProgressBar polls twice: Once during the dry_run phase, once during the installation phase. We have to manually stop the first polling although the method itself did not finish yet. It would be possible to not use this. But then I would need to say "finished" twice during one operation and I feel uncomfortable doing that. The progress bar reaches 100% after dry_run and jumps back to 0% when installation starts. One dry_run is "atomic" i.e. there are no steps in between (nothing like "Component added", "apt-get update", "Software changes calculated", etc). There is only progress when a remote or the local server answered completely. Because I needed a newer version of the frontend than present in errata3.1-1, I built it against 3.1-2 for now. Let me know what you think. univention-management-console-module-appcenter 2.0.140-1.117.201304042119 Is this really something that the ProgressBar should be able to handle - I do not see what exactly needs to be extended in the ProgressBar. IMHO should the module itself encapsulate several steps into transparent taks for the ProgressBar. This seems to be something module specific and not ProgressBar specific. New approach, less invasive: Just show a "spinning" progress bar stating "Performing software tests on involved systems". The check in the backend received a speed-up by using threads. This should roughly lead to the speed of "1 x single check" instead of "number of involved systems x single check" (maybe a bit slower during the second check when force=True). Downside: Absolutely no real progress information. It's done when it's done, it just looks nicer. 3.1-2: univention-management-console-module-appcenter 2.0.141-1.118.201304052144 errata not built until further decision (if this approach is acceptable). Built for 3.1-1: univention-management-console-module-appcenter 2.0.139-2.120.201304102007 Changelog updated, YAML created OK - errata3.1-1 OK - yaml OK - ucs3.1-2 OK - changelog |