Bug 31122
| Summary: | Cleanup.univention-management-console-module-udm/umc/python/udm/syntax.py | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Philipp Hahn <hahn> |
| Component: | UMC - Domain management (Generic) | Assignee: | UMC maintainers <umc-maintainers> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 | CC: | best, gohmann |
| Version: | UCS 3.1 | ||
| Target Milestone: | UCS 3.2-x | ||
| Hardware: | All | ||
| OS: | Linux | ||
| What kind of report is it?: | --- | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | Cleanup | |
| Max CVSS v3 score: | |||
| Attachments: | relative to svn40088 | ||
Created attachment 5180 [details] relative to svn40088 1. Break very long lines for readability 2. Use list comprehension instead of map() 3. Use 'value if test else value' instead of 'test and value or value' 4. Add documentation 5. Merge name and _widget_func to reduce invalid combinations: _widget_func() is only called when name is None, so name=None without _widget_func is invalid and _widget_func without name=None is silently ignored. 6. Fix re-definitions of global functions and variables TODO: Look at Widget.__contains__, is looks broken