Bug 31122 - Cleanup.univention-management-console-module-udm/umc/python/udm/syntax.py
Cleanup.univention-management-console-module-udm/umc/python/udm/syntax.py
Status: RESOLVED DUPLICATE of bug 39041
Product: UCS
Classification: Unclassified
Component: UMC - Domain management (Generic)
UCS 3.1
All Linux
: P5 minor (vote)
: UCS 3.2-x
Assigned To: UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-22 12:31 CEST by Philipp Hahn
Modified: 2015-08-17 11:03 CEST (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments
relative to svn40088 (8.63 KB, text/plain)
2013-04-22 12:31 CEST, Philipp Hahn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-04-22 12:31:27 CEST
Created attachment 5180 [details]
relative to svn40088

1. Break very long lines for readability
2. Use list comprehension instead of map()
3. Use 'value if test else value' instead of 'test and value or value'
4. Add documentation
5. Merge name and _widget_func to reduce invalid combinations: _widget_func()
is only called when name is None, so name=None without _widget_func is invalid
and _widget_func without name=None is silently ignored.
6. Fix re-definitions of global functions and variables

TODO: Look at Widget.__contains__, is looks broken
Comment 1 Florian Best univentionstaff 2015-08-17 11:03:57 CEST

*** This bug has been marked as a duplicate of bug 39041 ***