Univention Bugzilla – Full Text Bug Listing |
Summary: | Make sure that branding.json is used in standard UMC lib files (e.g. umc/tools.js) | ||
---|---|---|---|
Product: | UCS | Reporter: | Alexander Kläser <klaeser> |
Component: | UMC (Generic) | Assignee: | Florian Best <best> |
Status: | CLOSED FIXED | QA Contact: | Dirk Wiesenthal <wiesenthal> |
Severity: | enhancement | ||
Priority: | P5 | CC: | gohmann, jmm |
Version: | UCS 3.2 | ||
Target Milestone: | UCS 3.2-0-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: |
Description
Alexander Kläser
2013-11-20 16:59:56 CET
branding.json has been added to all umc-js files. univention-management-console-frontend 3.0.152-8.805.201401141007 Works as expected, did not find any file you missed. But I would like to see "umc/branding" in umc/i18n.js +171, too. Otherwise internationalization could get inconsistent (although I do not know how often this feature is used). See Bug #24864. One could even stop using params in the frontend when including umc/i18n (because branding and app are included automatically). Not sure, maybe this would be bad style (but it would have made this Bug a one-liner if this had been done before). (In reply to Dirk Wiesenthal from comment #2) > Works as expected, did not find any file you missed. But I would like to see > "umc/branding" in umc/i18n.js +171, too. Otherwise internationalization > could get inconsistent (although I do not know how often this feature is > used). See Bug #24864. > > One could even stop using params in the frontend when including umc/i18n > (because branding and app are included automatically). Not sure, maybe this > would be bad style (but it would have made this Bug a one-liner if this had > been done before). Agreed, to me it seems also a good idea to include umc/branding in umc/i18n.js (instead of integrating it in the other files). Probably one could remove umc/app from the UMC .js files, as well (then simply as "umc/i18n!", I guess). Ok Done OK I added a little check in order to ignore empty scopes and effectively avoid errors like "404 Not Found - http://192.168.122.250/i18n/de/.json". univention-management-console-frontend (3.0.152-17): * Bug #33493: ignore empty scopes OK |