Bug 33573

Summary: Abort installation and give error message when appcenter/app object manipulation fails
Product: UCS Reporter: Dirk Wiesenthal <wiesenthal>
Component: UMC - App-CenterAssignee: Dirk Wiesenthal <wiesenthal>
Status: CLOSED FIXED QA Contact: Florian Best <best>
Severity: normal    
Priority: P5 CC: gohmann, jmm
Version: UCS 3.2   
Target Milestone: UCS 3.2-0-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: --- What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:

Description Dirk Wiesenthal univentionstaff 2013-11-26 12:13:50 CET
E.g. installing on slave without master connection
Comment 1 Dirk Wiesenthal univentionstaff 2013-12-02 23:25:14 CET
Reworked the LDAP registration in
  univention-management-console-module-appcenter 3.0.50-16.229.201312021426

 * Now it is its own method of Application
   -> Needed to (un)register repositories correctly
 * If registration fails an error message is shown. Installation is successful nontheless
 * Registration is repeated each time the app center module is opened (even if nothing changed)
   -> Registration is done in the background, so this should not decrease performance notably
   -> Costs two seconds of background tasks in my tests
   -> Registration fails quasi-silently by only issuing a module.addWarning()
 * Fix all previous errors: Apps not yet registered are registered, app versions != installed version connected to localhost are unregistered
   -> Even finds those versions that do not have any ini file. See Bug#33535
Comment 2 Florian Best univentionstaff 2013-12-10 12:07:50 CET
The error message is now shown on every start of the app center if the master LDAP server is down even if there are no apps with pending registration.
Comment 3 Dirk Wiesenthal univentionstaff 2013-12-10 13:47:47 CET
(In reply to Florian Best from comment #2)
> The error message is now shown on every start of the app center if the
> master LDAP server is down even if there are no apps with pending
> registration.

Yes. But the warning also contains the sentence: "This may also cause problems when installing applications". So the warning is not useless.

Furthermore, I cannot know which apps have pending registration before I looked up LDAP. I could save the status (for all locally installed apps) in another file and keep it up to date. But it is error prone and still I do not know whether this is correct. See Bug#33535: Apps think everything is okay, but in fact there are some bogus versions lying around.
Comment 4 Dirk Wiesenthal univentionstaff 2013-12-10 14:44:32 CET
As discussed. If this is bothering the users we might have to rethink it. For now, FIXED
Comment 5 Florian Best univentionstaff 2013-12-10 16:41:10 CET
(In reply to Dirk Wiesenthal from comment #4)
> As discussed. If this is bothering the users we might have to rethink it.
> For now, FIXED
Yes ;)

* OK Applications are registered when e.g. the LDAP server is up again
* OK Error message is correct when installation fails due to not able to register; the installation succeeds
* OK YAML
Comment 6 Moritz Muehlenhoff univentionstaff 2013-12-12 11:30:50 CET
http://errata.univention.de/ucs/3.2/8.html